Merge branch 'main' into update-name-length-check

Author: arrowtype

CHANGELOG.md

@@ -7,7 +7,19 @@ A more detailed list of changes is available in the corresponding milestones for
 ### On the Universal profile
   - **[name/family_and_style_max_length]:** Update to account for STAT table, along with recent testing and observations contributed to issue #2179
 
-##  1.0.0 (2025-May-07)
+## 1.0.1 (2025-Jul-04)
+### Bugfixes
+  - fonttools==4.58.0 has been changed (PR #https://github.com/fonttools/fonttools/pull/3809/): It fixes duplicate names, therefore the test for the `unique_glyphnames`check was failing. (issue #5023)
+  - Fix passing legacy check ids to --exclude-checkid (PR #5032)
+
+### On the OpenType profile
+  - **[check_monospace]:** Check CFF fonts as well: remove conditions "is_ttf" + remove "glyf" from required tables (issue #5030)
+
+### On the Universal profile
+  - **[base_has_width]** is no longer considered experimental.
+
+
+## 1.0.0 (2025-May-07)
   - See also: https://github.com/fonttools/fontspector
 
 ### Migration of checks

Lib/fontbakery/checkrunner.py

@@ -238,6 +238,17 @@ def _run_check(self, identity: Identity):
 
     @property
     def order(self) -> Tuple[Identity, ...]:
+        # map old excluded check ids to new ones
+        _exclude_checks = None
+        if self._exclude_checks:
+            _exclude_checks = []
+            for excluded in self._exclude_checks:
+                if excluded in old_to_new:
+                    self.legacy_checkid_references.add(excluded)
+                    _exclude_checks.append(old_to_new[excluded])
+                else:
+                    _exclude_checks.append(excluded)
+
         _order = []
         for section in self.profile.sections:
             for check in section.checks:
@@ -260,15 +271,13 @@ def order(self) -> Tuple[Identity, ...]:
                     if not selected_via_legacy_checkid and not selected_via_new_checkid:
                         continue
 
-                if self._exclude_checks:
-                    if any(excluded in check.id for excluded in self._exclude_checks):
+                if _exclude_checks:
+                    if any(excluded in check.id for excluded in _exclude_checks):
                         continue
 
                     if check.id in self.new_to_old:
                         for legacy in self.new_to_old[check.id]:
-                            if any(
-                                excluded in legacy for excluded in self._exclude_checks
-                            ):
+                            if any(excluded in legacy for excluded in _exclude_checks):
                                 self.legacy_checkid_references.add(legacy)
                                 continue
 

Lib/fontbakery/checks/base_has_width.py

@@ -27,7 +27,6 @@ def is_space(codepoint):
         Base characters should have non-zero advance width.
     """,
     proposal="https://github.com/fonttools/fontbakery/issues/4906",
-    experimental="Since 2024/12/28",
 )
 def check_base_has_width(font, config):
     """Check base characters have non-zero advance width."""

Lib/fontbakery/checks/interpolation_issues.py

@@ -4,7 +4,7 @@
 from fontTools.varLib.interpolatableHelpers import InterpolatableProblem
 from fontTools.varLib.models import piecewiseLinearMap
 
-from fontbakery.prelude import check, Message, PASS, WARN
+from fontbakery.prelude import PASS, SKIP, WARN, Message, check
 from fontbakery.utils import bullet_list
 
 
@@ -25,6 +25,9 @@
 )
 def check_interpolation_issues(ttFont, config):
     """Detect any interpolation issues in the font."""
+    if "gvar" not in ttFont:
+        yield SKIP, Message("interpolation-issues", "The font has no gvar table.")
+        return
 
     gvar = ttFont["gvar"]
     # This code copied from fontTools.varLib.interpolatable

Lib/fontbakery/checks/opentype/monospace.py

@@ -67,7 +67,7 @@ def PANOSE_expected(family_type):
 
 @check(
     id="opentype/monospace",
-    conditions=["glyph_metrics_stats", "is_ttf"],
+    conditions=["glyph_metrics_stats"],
     rationale="""
         There are various metadata in the OpenType spec to specify if a font is
         monospaced or not. If the font is not truly monospaced, then no monospaced
@@ -118,7 +118,7 @@ def check_monospace(ttFont, glyph_metrics_stats):
 
     # Check for missing tables before indexing them
     missing_tables = False
-    required = ["glyf", "hhea", "hmtx", "OS/2", "post"]
+    required = ["hhea", "hmtx", "OS/2", "post"]
     for key in required:
         if key not in ttFont:
             missing_tables = True

Lib/fontbakery/checks/opentype/varfont/STAT_axis_record_for_each_axis.py

@@ -1,4 +1,4 @@
-from fontbakery.prelude import check, Message, FAIL, PASS
+from fontbakery.prelude import FAIL, PASS, SKIP, Message, check
 from fontbakery.utils import bullet_list
 
 
@@ -16,6 +16,10 @@
 def check_varfont_STAT_axis_record_for_each_axis(ttFont, config):
     """All fvar axes have a correspondent Axis Record on STAT table?"""
     fvar_axes = set(a.axisTag for a in ttFont["fvar"].axes)
+    if "STAT" not in ttFont:
+        yield SKIP, Message("missing-axis-records", "The font has no STAT table.")
+        return
+
     STAT_axes = set(a.AxisTag for a in ttFont["STAT"].table.DesignAxisRecord.Axis)
     missing_axes = fvar_axes - STAT_axes
     if len(missing_axes) > 0: