Make the test a bit more interesting

Change one of the instances subfamily instead of the font’s family name.

Author: khaledhosny

tests/test_checks_name.py

@@ -96,9 +96,10 @@ def test_check_instances_name_length_req(check, test_ttFont):
 
     assert_PASS(check(test_ttFont), "with a good font...")
 
+    instance = test_ttFont["fvar"].instances[0]
     test_ttFont_bad = copy.deepcopy(test_ttFont)
     for rec in test_ttFont_bad["name"].names:
-        if rec.nameID in (NameID.FONT_FAMILY_NAME, NameID.TYPOGRAPHIC_FAMILY_NAME):
+        if rec.nameID == instance.subfamilyNameID:
             rec.string = "A" * 32
     assert_results_contain(check(test_ttFont_bad), FAIL, "long-name")