fixes check_monospace to also work with CFF

* Extend test_check_monospace to fail with CFF
* Fix "opentype/monospace": remove conditions "is_ttf" + remove "glyf" from required tables

On the opentype profile.

(issue #5030)

Author: ollimeier

CHANGELOG.md

@@ -5,6 +5,10 @@ A more detailed list of changes is available in the corresponding milestones for
 ### Bugfixes
 - fonttools==4.58.0 has been changed (PR #https://github.com/fonttools/fonttools/pull/3809/): It fixes duplicate names, therefore the test for the `unique_glyphnames`check was failing. (issue #5023)
 
+### On the opentype profile
+- **[check_monospace]:** Check CFF fonts as well: remove conditions "is_ttf" + remove "glyf" from required tables (issue #5030)
+
+
 ## 1.0.0 (2025-May-07)
   - See also: https://github.com/fonttools/fontspector
 

Lib/fontbakery/checks/opentype/monospace.py

@@ -67,7 +67,7 @@ def PANOSE_expected(family_type):
 
 @check(
     id="opentype/monospace",
-    conditions=["glyph_metrics_stats", "is_ttf"],
+    conditions=["glyph_metrics_stats"],
     rationale="""
         There are various metadata in the OpenType spec to specify if a font is
         monospaced or not. If the font is not truly monospaced, then no monospaced
@@ -118,7 +118,7 @@ def check_monospace(ttFont, glyph_metrics_stats):
 
     # Check for missing tables before indexing them
     missing_tables = False
-    required = ["glyf", "hhea", "hmtx", "OS/2", "post"]
+    required = ["hhea", "hmtx", "OS/2", "post"]
     for key in required:
         if key not in ttFont:
             missing_tables = True

tests/test_checks_opentype_name.py

@@ -191,6 +191,14 @@ def test_check_monospace(check):
     del ttFont["OS/2"]
     assert_results_contain(check(ttFont), FAIL, "lacks-table")
 
+    # --------------------------------------------
+    # And now we test a CFF font:
+    # --------------------------------------------
+    ttFont = TTFont(TEST_FILE("source-sans-pro/OTF/SourceSansPro-Regular.otf"))
+    assert_results_contain(
+        check(ttFont), PASS, "good", "with a good non-monospace font..."
+    )
+
 
 @check_id("opentype/name/match_familyname_fullfont")
 def test_check_name_match_familyname_fullfont(check):