Add delete and edit commands for managing individual notes

Author: fprochazka

README.md

@@ -77,6 +77,23 @@ glab-discussion resolve DISCUSSION_ID
 glab-discussion resolve DISCUSSION_ID --unresolve
 ```
 
+### edit
+
+Edit an existing note's body.
+
+```bash
+glab-discussion edit NOTE_ID --body "Updated text"
+echo "From stdin" | glab-discussion edit NOTE_ID --body -
+```
+
+### delete
+
+Delete a note.
+
+```bash
+glab-discussion delete NOTE_ID
+```
+
 ## Requirements
 
 - [`glab` CLI](https://docs.gitlab.com/cli/) installed and authenticated

coding-agent-plugins/claude-code/skills/glab-discussion/SKILL.md

@@ -3,9 +3,9 @@ name: glab-discussion
 description: >-
   This skill should be used when the user asks to "read MR discussions",
   "list MR comments", "reply to a discussion", "resolve a discussion",
-  "add a diff note", "review MR comments", "dump discussions",
-  "show MR diff for commenting", or needs to interact with GitLab merge request
-  discussions. Provides CLI reference for the glab-discussion tool.
+  "edit a comment", "delete a comment", "add a diff note", "review MR comments",
+  "dump discussions", "show MR diff for commenting", or needs to interact with
+  GitLab merge request discussions. Provides CLI reference for the glab-discussion tool.
 ---
 
 # glab-discussion CLI
@@ -93,6 +93,19 @@ glab-discussion resolve <discussion_id>
 glab-discussion resolve <discussion_id> --unresolve
 ```
 
+### edit — Edit an existing note
+
+```bash
+glab-discussion edit <note_id> --body "Updated text"
+glab-discussion edit <note_id> --body -                          # read body from stdin
+```
+
+### delete — Delete a note
+
+```bash
+glab-discussion delete <note_id>
+```
+
 ## Resolving GitLab UI URLs
 
 GitLab UI links to specific notes use `#note_<id>` anchors (e.g.
@@ -113,6 +126,8 @@ and also in the filename suffix.
 3. **Check diff context:** `glab-discussion diff --file <path>` to see commentable lines
 4. **Reply:** `glab-discussion write --reply-to <id> --body "..."`
 5. **Add diff note:** `glab-discussion write --file <path> --new-line <n> --body "..."`
-6. **Resolve:** `glab-discussion resolve <id>`
-7. **Re-read:** `glab-discussion read` to see updated state (incremental, only changed files)
+6. **Edit a note:** `glab-discussion edit <note_id> --body "..."`
+7. **Delete a note:** `glab-discussion delete <note_id>`
+8. **Resolve:** `glab-discussion resolve <id>`
+9. **Re-read:** `glab-discussion read` to see updated state (incremental, only changed files)
 

src/glab_discussion/cli.py

@@ -43,6 +43,15 @@ def main(argv: list[str] | None = None) -> None:
     resolve_parser.add_argument("discussion_id", help="Discussion ID to resolve")
     resolve_parser.add_argument("--unresolve", action="store_true", default=False, help="Unresolve instead of resolve")
 
+    # --- delete ---
+    delete_parser = subparsers.add_parser("delete", parents=[mr_parent], help="Delete a note")
+    delete_parser.add_argument("note_id", type=int, help="Note ID to delete")
+
+    # --- edit ---
+    edit_parser = subparsers.add_parser("edit", parents=[mr_parent], help="Edit a note")
+    edit_parser.add_argument("note_id", type=int, help="Note ID to edit")
+    edit_parser.add_argument("--body", required=True, help='New note body text (use "-" for stdin)')
+
     args = parser.parse_args(argv)
 
     if args.command == "read":
@@ -60,6 +69,14 @@ def main(argv: list[str] | None = None) -> None:
     elif args.command == "resolve":
         from glab_discussion.commands.resolve import run
 
+        run(args)
+    elif args.command == "delete":
+        from glab_discussion.commands.delete import run
+
+        run(args)
+    elif args.command == "edit":
+        from glab_discussion.commands.edit import run
+
         run(args)
     else:
         parser.print_help()

src/glab_discussion/commands/delete.py

@@ -0,0 +1,18 @@
+from __future__ import annotations
+
+import argparse
+
+from glab_discussion.api import glab_api
+from glab_discussion.context import resolve_mr_context
+
+
+def run(args: argparse.Namespace) -> None:
+    ctx = resolve_mr_context(args)
+
+    glab_api(
+        f"projects/{ctx.project_id}/merge_requests/{ctx.mr_iid}/notes/{args.note_id}",
+        method="DELETE",
+        hostname=ctx.hostname,
+    )
+
+    print(f"Deleted note {args.note_id}")

src/glab_discussion/commands/edit.py

@@ -0,0 +1,22 @@
+from __future__ import annotations
+
+import argparse
+import sys
+
+from glab_discussion.api import glab_api
+from glab_discussion.context import resolve_mr_context
+
+
+def run(args: argparse.Namespace) -> None:
+    ctx = resolve_mr_context(args)
+
+    body = sys.stdin.read() if args.body == "-" else args.body
+
+    glab_api(
+        f"projects/{ctx.project_id}/merge_requests/{ctx.mr_iid}/notes/{args.note_id}",
+        method="PUT",
+        raw_fields={"body": body},
+        hostname=ctx.hostname,
+    )
+
+    print(f"Edited note {args.note_id}")

tests/test_cli.py

@@ -43,6 +43,31 @@ def test_resolve_help(self, capsys) -> None:
         assert "discussion_id" in captured.out
         assert "--unresolve" in captured.out
 
+    def test_delete_help(self, capsys) -> None:
+        with pytest.raises(SystemExit) as exc_info:
+            main(["delete", "--help"])
+        assert exc_info.value.code == 0
+        captured = capsys.readouterr()
+        assert "note_id" in captured.out
+
+    def test_edit_help(self, capsys) -> None:
+        with pytest.raises(SystemExit) as exc_info:
+            main(["edit", "--help"])
+        assert exc_info.value.code == 0
+        captured = capsys.readouterr()
+        assert "note_id" in captured.out
+        assert "--body" in captured.out
+
+    def test_delete_requires_note_id(self) -> None:
+        with pytest.raises(SystemExit) as exc_info:
+            main(["delete"])
+        assert exc_info.value.code == 2
+
+    def test_edit_requires_body(self) -> None:
+        with pytest.raises(SystemExit) as exc_info:
+            main(["edit", "123"])
+        assert exc_info.value.code == 2
+
     def test_invalid_command(self) -> None:
         with pytest.raises(SystemExit) as exc_info:
             main(["nonexistent"])

tests/test_delete.py

@@ -0,0 +1,34 @@
+from __future__ import annotations
+
+from argparse import Namespace
+from unittest.mock import patch
+
+from glab_discussion.commands.delete import run
+from glab_discussion.models import MrContext
+
+
+class TestDelete:
+    def test_delete_note(self, capsys) -> None:
+        ctx = MrContext(
+            hostname="gitlab.com",
+            project_id=42,
+            project_path="group/project",
+            mr_iid=7,
+            mr_url="https://gitlab.com/group/project/-/merge_requests/7",
+        )
+
+        with (
+            patch("glab_discussion.commands.delete.resolve_mr_context", return_value=ctx),
+            patch("glab_discussion.commands.delete.glab_api") as mock_api,
+        ):
+            args = Namespace(note_id=99999)
+            run(args)
+
+            mock_api.assert_called_once_with(
+                "projects/42/merge_requests/7/notes/99999",
+                method="DELETE",
+                hostname="gitlab.com",
+            )
+
+        captured = capsys.readouterr()
+        assert "Deleted note 99999" in captured.out

tests/test_edit.py

@@ -0,0 +1,63 @@
+from __future__ import annotations
+
+from argparse import Namespace
+from unittest.mock import patch
+
+from glab_discussion.commands.edit import run
+from glab_discussion.models import MrContext
+
+
+class TestEdit:
+    def test_edit_note(self, capsys) -> None:
+        ctx = MrContext(
+            hostname="gitlab.com",
+            project_id=42,
+            project_path="group/project",
+            mr_iid=7,
+            mr_url="https://gitlab.com/group/project/-/merge_requests/7",
+        )
+
+        with (
+            patch("glab_discussion.commands.edit.resolve_mr_context", return_value=ctx),
+            patch("glab_discussion.commands.edit.glab_api") as mock_api,
+        ):
+            args = Namespace(note_id=99999, body="Updated text")
+            run(args)
+
+            mock_api.assert_called_once_with(
+                "projects/42/merge_requests/7/notes/99999",
+                method="PUT",
+                raw_fields={"body": "Updated text"},
+                hostname="gitlab.com",
+            )
+
+        captured = capsys.readouterr()
+        assert "Edited note 99999" in captured.out
+
+    def test_edit_note_stdin(self, capsys) -> None:
+        ctx = MrContext(
+            hostname="gitlab.com",
+            project_id=42,
+            project_path="group/project",
+            mr_iid=7,
+            mr_url="https://gitlab.com/group/project/-/merge_requests/7",
+        )
+
+        with (
+            patch("glab_discussion.commands.edit.resolve_mr_context", return_value=ctx),
+            patch("glab_discussion.commands.edit.glab_api") as mock_api,
+            patch("glab_discussion.commands.edit.sys") as mock_sys,
+        ):
+            mock_sys.stdin.read.return_value = "Body from stdin"
+            args = Namespace(note_id=88888, body="-")
+            run(args)
+
+            mock_api.assert_called_once_with(
+                "projects/42/merge_requests/7/notes/88888",
+                method="PUT",
+                raw_fields={"body": "Body from stdin"},
+                hostname="gitlab.com",
+            )
+
+        captured = capsys.readouterr()
+        assert "Edited note 88888" in captured.out