Try converting from things like np.int_ to np.dtype

Author: franzpoeschel

include/openPMD/binding/python/Numpy.hpp

@@ -98,6 +98,20 @@ inline Datatype dtype_from_numpy(pybind11::dtype const dt)
     }
 }
 
+inline Datatype dtype_from_numpy(pybind11::object const &dt)
+{
+    if (py::isinstance<pybind11::dtype>(dt))
+    {
+        return dtype_from_numpy(py::cast<pybind11::dtype>(dt));
+    }
+    else
+    {
+        auto numpy = pybind11::module_::import("numpy");
+        auto create_dtype = numpy.attr("dtype");
+        return dtype_from_numpy(py::cast<pybind11::dtype>(create_dtype(dt)));
+    }
+}
+
 /** Return openPMD::Datatype from py::buffer_info::format
  */
 inline Datatype dtype_from_bufferformat(std::string const &fmt)
@@ -239,4 +253,5 @@ inline pybind11::dtype dtype_to_numpy(Datatype const dt)
         throw std::runtime_error("dtype_to_numpy: Invalid Datatype!");
     }
 }
+
 } // namespace openPMD

src/binding/python/Dataset.cpp

@@ -37,10 +37,11 @@ void init_Dataset(py::module &m)
                 py::arg("extent"),
                 py::arg("options") = "{}")
             .def(
-                py::init([](py::dtype dt, Extent e, std::string options) {
-                    auto const d = dtype_from_numpy(std::move(dt));
-                    return new Dataset{d, std::move(e), std::move(options)};
-                }),
+                py::init(
+                    [](py::object const &dt, Extent e, std::string options) {
+                        auto const d = dtype_from_numpy(dt);
+                        return new Dataset{d, std::move(e), std::move(options)};
+                    }),
                 py::arg("dtype"),
                 py::arg("extent"),
                 py::arg("options") = "{}")
@@ -54,8 +55,10 @@ void init_Dataset(py::module &m)
                 py::arg("extent"),
                 py::arg("options"))
             .def(
-                py::init([](py::dtype dt, Extent e, py::object const &options) {
-                    auto const d = dtype_from_numpy(std::move(dt));
+                py::init([](py::object const &dt,
+                            Extent e,
+                            py::object const &options) {
+                    auto const d = dtype_from_numpy(dt);
                     auto resolved_options = ::auxiliary::json_dumps(options);
                     return new Dataset{
                         d, std::move(e), std::move(resolved_options)};