HDF5: proper status check (openPMD#1870)

franzpoeschel · web-flow · commit 3a290ec925d6 · 2026-04-07T15:44:29.000Z
diff --git a/src/IO/HDF5/HDF5IOHandler.cpp b/src/IO/HDF5/HDF5IOHandler.cpp
@@ -2015,7 +2015,7 @@ void HDF5IOHandlerImpl::writeDataset(
         "write");
     auto defer_close_dataType = auxiliary::defer([&]() {
         status = H5Tclose(dataType);
-        if (status == 0)
+        if (status != 0)
         {
             std::cerr << "[HDF5] Internal error: Failed to close dataset "
                          "datatype during dataset write."

Original file line number	Diff line number	Diff line change
`@@ -2015,7 +2015,7 @@ void HDF5IOHandlerImpl::writeDataset(`
`2015`	`2015`	`"write");`
`2016`	`2016`	`auto defer_close_dataType = auxiliary::defer([&]() {`
`2017`	`2017`	`status = H5Tclose(dataType);`
`2018`		`- if (status == 0)`
	`2018`	`+ if (status != 0)`
`2019`	`2019`	`{`
`2020`	`2020`	`std::cerr << "[HDF5] Internal error: Failed to close dataset "`
`2021`	`2021`	`"datatype during dataset write."`