Skip to content

Commit 6b2454b

Browse files
committed
Revert some WIPs
1 parent e61b646 commit 6b2454b

1 file changed

Lines changed: 26 additions & 27 deletions

File tree

test/SerialIOTest.cpp

Lines changed: 26 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1764,31 +1764,31 @@ inline void write_test(
17641764
#ifndef _WIN32
17651765
if (test_rank_table)
17661766
{
1767-
REQUIRE(read.rankTable(/* collective = */ false) == compare);
1767+
// REQUIRE(read.rankTable(/* collective = */ false) == compare);
17681768
}
17691769
#endif
17701770
}
17711771

17721772
TEST_CASE("write_test", "[serial]")
17731773
{
1774-
for (auto const &t : {std::string("json")})
1774+
for (auto const &t : testedFileExtensions())
17751775
{
17761776
if (t == "json")
17771777
{
1778-
// write_test(
1779-
// "template." + t,
1780-
// R"(
1781-
// {
1782-
// "json": {
1783-
// "dataset": {
1784-
// "mode": "template"
1785-
// },
1786-
// "attribute": {
1787-
// "mode": "short"
1788-
// }
1789-
// }
1790-
// })",
1791-
// false);
1778+
write_test(
1779+
"template." + t,
1780+
R"(
1781+
{
1782+
"json": {
1783+
"dataset": {
1784+
"mode": "template"
1785+
},
1786+
"attribute": {
1787+
"mode": "short"
1788+
}
1789+
}
1790+
})",
1791+
false);
17921792
write_test(
17931793
t,
17941794
R"(
@@ -2353,20 +2353,19 @@ inline void fileBased_write_test(const std::string &backend)
23532353

23542354
TEST_CASE("fileBased_write_test", "[serial]")
23552355
{
2356-
for (auto const &t : {"bp5"})
2356+
for (auto const &t : testedFileExtensions())
23572357
{
23582358
fileBased_write_test(t);
23592359
}
2360-
// if (auto extensions = getFileExtensions();
2361-
// std::find(extensions.begin(), extensions.end(), "toml") !=
2362-
// extensions.end())
2363-
// { /*
2364-
// * TOML backend is not generally tested for performance reasons, opt in
2365-
// to
2366-
// * testing it here.
2367-
// */
2368-
// fileBased_write_test("toml");
2369-
// }
2360+
if (auto extensions = getFileExtensions();
2361+
std::find(extensions.begin(), extensions.end(), "toml") !=
2362+
extensions.end())
2363+
{ /*
2364+
* TOML backend is not generally tested for performance reasons, opt in to
2365+
* testing it here.
2366+
*/
2367+
fileBased_write_test("toml");
2368+
}
23702369
}
23712370

23722371
inline void sample_write_thetaMode(std::string const &file_ending)

0 commit comments

Comments
 (0)