Skip to content

Commit b5403e6

Browse files
franzpoeschelfranzpoeschel
committed
Mark all remaining places that need to be dealt with
1 parent a24a693 commit b5403e6

1 file changed

Lines changed: 30 additions & 30 deletions

File tree

‎src/IO/HDF5/HDF5IOHandler.cpp‎

Lines changed: 30 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -451,7 +451,7 @@ void HDF5IOHandlerImpl::createPath(
451451
/* Close the groups */
452452
while (!groups.empty())
453453
{
454-
status = H5Gclose(groups.top());
454+
status = H5Gclose(groups.top()); //
455455
VERIFY(
456456
status == 0,
457457
"[HDF5] Internal error: Failed to close HDF5 group during path "
@@ -466,7 +466,7 @@ void HDF5IOHandlerImpl::createPath(
466466
m_fileNames[writable] = file.name;
467467
}
468468

469-
status = H5Pclose(gapl);
469+
status = H5Pclose(gapl); //
470470
VERIFY(
471471
status == 0,
472472
"[HDF5] Internal error: Failed to close HDF5 property during path "
@@ -1065,32 +1065,32 @@ void HDF5IOHandlerImpl::createDataset(
10651065
"creation");
10661066

10671067
herr_t status;
1068-
status = H5Dclose(group_id);
1068+
status = H5Dclose(group_id); //
10691069
VERIFY(
10701070
status == 0,
10711071
"[HDF5] Internal error: Failed to close HDF5 dataset during "
10721072
"dataset creation");
1073-
status = H5Tclose(datatype);
1073+
status = H5Tclose(datatype); //
10741074
VERIFY(
10751075
status == 0,
10761076
"[HDF5] Internal error: Failed to close HDF5 datatype during "
10771077
"dataset creation");
1078-
status = H5Pclose(datasetCreationProperty);
1078+
status = H5Pclose(datasetCreationProperty); //
10791079
VERIFY(
10801080
status == 0,
10811081
"[HDF5] Internal error: Failed to close HDF5 dataset creation "
10821082
"property during dataset creation");
1083-
status = H5Sclose(space);
1083+
status = H5Sclose(space); //
10841084
VERIFY(
10851085
status == 0,
10861086
"[HDF5] Internal error: Failed to close HDF5 dataset space during "
10871087
"dataset creation");
1088-
status = H5Gclose(node_id);
1088+
status = H5Gclose(node_id); //
10891089
VERIFY(
10901090
status == 0,
10911091
"[HDF5] Internal error: Failed to close HDF5 group during dataset "
10921092
"creation");
1093-
status = H5Pclose(gapl);
1093+
status = H5Pclose(gapl); //
10941094
VERIFY(
10951095
status == 0,
10961096
"[HDF5] Internal error: Failed to close HDF5 property during "
@@ -1168,7 +1168,7 @@ void HDF5IOHandlerImpl::extendDataset(
11681168
"[HDF5] Internal error: Failed to extend HDF5 dataset during dataset "
11691169
"extension");
11701170

1171-
status = H5Dclose(dataset_id);
1171+
status = H5Dclose(dataset_id); //
11721172
VERIFY(
11731173
status == 0,
11741174
"[HDF5] Internal error: Failed to close HDF5 dataset during dataset "
@@ -1232,13 +1232,13 @@ void HDF5IOHandlerImpl::availableChunks(
12321232
parameters.chunks->emplace_back(std::move(offset), std::move(extent));
12331233

12341234
herr_t status;
1235-
status = H5Sclose(dataset_space);
1235+
status = H5Sclose(dataset_space); //
12361236
VERIFY(
12371237
status == 0,
12381238
"[HDF5] Internal error: Failed to close HDF5 dataset space during "
12391239
"availableChunks task");
12401240

1241-
status = H5Dclose(dataset_id);
1241+
status = H5Dclose(dataset_id); //
12421242
VERIFY(
12431243
status == 0,
12441244
"[HDF5] Internal error: Failed to close HDF5 dataset during "
@@ -1363,7 +1363,7 @@ void HDF5IOHandlerImpl::openPath(
13631363
}
13641364

13651365
herr_t status;
1366-
status = H5Gclose(path_id);
1366+
status = H5Gclose(path_id); //
13671367
if (status != 0)
13681368
{
13691369
throw error::ReadError(
@@ -1376,7 +1376,7 @@ void HDF5IOHandlerImpl::openPath(
13761376
}
13771377

13781378
herr_t status;
1379-
status = H5Gclose(node_id);
1379+
status = H5Gclose(node_id); //
13801380
if (status != 0)
13811381
{
13821382
throw error::ReadError(
@@ -1386,7 +1386,7 @@ void HDF5IOHandlerImpl::openPath(
13861386
"[HDF5] Internal error: Failed to close HDF5 group during path "
13871387
"opening");
13881388
}
1389-
status = H5Pclose(gapl);
1389+
status = H5Pclose(gapl); //
13901390
if (status != 0)
13911391
{
13921392
throw error::ReadError(
@@ -1546,12 +1546,12 @@ void HDF5IOHandlerImpl::openDataset(
15461546
}
15471547
else if (H5Tequal(dataset_type, next_type))
15481548
{
1549-
H5Tclose(next_type);
1549+
H5Tclose(next_type); //
15501550
throw_error();
15511551
}
15521552
else
15531553
{
1554-
if (H5Tclose(dataset_type) != 0)
1554+
if (H5Tclose(dataset_type) != 0) //
15551555
{
15561556
throw error::ReadError(
15571557
error::AffectedObject::Group,
@@ -1599,7 +1599,7 @@ void HDF5IOHandlerImpl::openDataset(
15991599
}
16001600

16011601
herr_t status;
1602-
status = H5Sclose(dataset_space);
1602+
status = H5Sclose(dataset_space); //
16031603
if (status != 0)
16041604
{
16051605
throw error::ReadError(
@@ -1609,7 +1609,7 @@ void HDF5IOHandlerImpl::openDataset(
16091609
"Internal error: Failed to close HDF5 dataset space during "
16101610
"dataset opening");
16111611
}
1612-
status = H5Tclose(dataset_type);
1612+
status = H5Tclose(dataset_type); //
16131613
if (status != 0)
16141614
{
16151615
throw error::ReadError(
@@ -1619,7 +1619,7 @@ void HDF5IOHandlerImpl::openDataset(
16191619
"Internal error: Failed to close HDF5 dataset type during "
16201620
"dataset opening");
16211621
}
1622-
status = H5Dclose(dataset_id);
1622+
status = H5Dclose(dataset_id); //
16231623
if (status != 0)
16241624
{
16251625
throw error::ReadError(
@@ -1629,7 +1629,7 @@ void HDF5IOHandlerImpl::openDataset(
16291629
"Internal error: Failed to close HDF5 dataset during dataset "
16301630
"opening");
16311631
}
1632-
status = H5Gclose(node_id);
1632+
status = H5Gclose(node_id); //
16331633
if (status != 0)
16341634
{
16351635
throw error::ReadError(
@@ -1639,7 +1639,7 @@ void HDF5IOHandlerImpl::openDataset(
16391639
"Internal error: Failed to close HDF5 group during dataset "
16401640
"opening");
16411641
}
1642-
status = H5Pclose(gapl);
1642+
status = H5Pclose(gapl); //
16431643
if (status != 0)
16441644
{
16451645
throw error::ReadError(
@@ -1730,7 +1730,7 @@ void HDF5IOHandlerImpl::deletePath(
17301730
VERIFY(
17311731
status == 0, "[HDF5] Internal error: Failed to delete HDF5 group");
17321732

1733-
status = H5Gclose(node_id);
1733+
status = H5Gclose(node_id); //
17341734
VERIFY(
17351735
status == 0,
17361736
"[HDF5] Internal error: Failed to close HDF5 group during path "
@@ -1782,7 +1782,7 @@ void HDF5IOHandlerImpl::deleteDataset(
17821782
VERIFY(
17831783
status == 0, "[HDF5] Internal error: Failed to delete HDF5 group");
17841784

1785-
status = H5Gclose(node_id);
1785+
status = H5Gclose(node_id); //
17861786
VERIFY(
17871787
status == 0,
17881788
"[HDF5] Internal error: Failed to close HDF5 group during dataset "
@@ -1959,22 +1959,22 @@ void HDF5IOHandlerImpl::writeDataset(
19591959
default:
19601960
throw std::runtime_error("[HDF5] Datatype not implemented in HDF5 IO");
19611961
}
1962-
status = H5Tclose(dataType);
1962+
status = H5Tclose(dataType); //
19631963
VERIFY(
19641964
status == 0,
19651965
"[HDF5] Internal error: Failed to close dataset datatype during "
19661966
"dataset write");
1967-
status = H5Sclose(filespace);
1967+
status = H5Sclose(filespace); //
19681968
VERIFY(
19691969
status == 0,
19701970
"[HDF5] Internal error: Failed to close dataset file space during "
19711971
"dataset write");
1972-
status = H5Sclose(memspace);
1972+
status = H5Sclose(memspace); //
19731973
VERIFY(
19741974
status == 0,
19751975
"[HDF5] Internal error: Failed to close dataset memory space during "
19761976
"dataset write");
1977-
status = H5Dclose(dataset_id);
1977+
status = H5Dclose(dataset_id); //
19781978
VERIFY(
19791979
status == 0,
19801980
"[HDF5] Internal error: Failed to close dataset " +
@@ -2075,7 +2075,7 @@ void HDF5IOHandlerImpl::writeAttribute(
20752075
node_id >= 0,
20762076
"[HDF5] Internal error: Failed to create HDF5 attribute during "
20772077
"attribute write");
2078-
status = H5Sclose(dataspace);
2078+
status = H5Sclose(dataspace); //
20792079
VERIFY(
20802080
status == 0,
20812081
"[HDF5] Internal error: Failed to close HDF5 dataspace during "
@@ -2503,7 +2503,7 @@ void HDF5IOHandlerImpl::readDataset(
25032503
{
25042504
dataType = m_H5T_LONG_DOUBLE_80_LE;
25052505
}
2506-
status = H5Tclose(checkDatasetTypeAgain);
2506+
status = H5Tclose(checkDatasetTypeAgain); //
25072507
VERIFY(
25082508
status == 0,
25092509
"[HDF5] Internal error: Failed to close HDF5 dataset type during "
@@ -2517,7 +2517,7 @@ void HDF5IOHandlerImpl::readDataset(
25172517
{
25182518
dataType = m_H5T_CLONG_DOUBLE_80_LE;
25192519
}
2520-
status = H5Tclose(checkDatasetTypeAgain);
2520+
status = H5Tclose(checkDatasetTypeAgain); //
25212521
VERIFY(
25222522
status == 0,
25232523
"[HDF5] Internal error: Failed to close HDF5 dataset type during "

0 commit comments

Comments
 (0)
⚡