Merge pull request #52152 from rohitwaghchaure/refactor-reposting-feature

Refactor reposting feature

Author: rohitwaghchaure

erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.js

@@ -69,9 +69,15 @@ frappe.ui.form.on("Repost Item Valuation", {
 			}
 
 			if (frm.doc.status == "In Progress") {
-				frm.doc.current_index = data.current_index;
-				frm.doc.items_to_be_repost = data.items_to_be_repost;
-				frm.doc.total_reposting_count = data.total_reposting_count;
+				if (data.current_index) {
+					frm.doc.current_index = data.current_index;
+					frm.doc.items_to_be_repost = data.items_to_be_repost;
+				}
+
+				if (data.vouchers_posted) {
+					frm.doc.total_vouchers = data.total_vouchers;
+					frm.doc.vouchers_posted = data.vouchers_posted;
+				}
 
 				frm.dashboard.reset();
 				frm.trigger("show_reposting_progress");
@@ -108,23 +114,39 @@ frappe.ui.form.on("Repost Item Valuation", {
 
 	show_reposting_progress: function (frm) {
 		var bars = [];
-
+		let title = "";
+		let progress = 0.0;
 		let total_count = frm.doc.items_to_be_repost ? JSON.parse(frm.doc.items_to_be_repost).length : 0;
 
-		if (frm.doc?.total_reposting_count) {
-			total_count = frm.doc.total_reposting_count;
+		if (total_count > 1) {
+			progress = flt((cint(frm.doc.current_index) / total_count) * 100, 2) || 0.5;
+			title = __("Reposting for Item-Wh Completed {0}%", [progress]);
+
+			bars.push({
+				title: title,
+				width: progress + "%",
+				progress_class: "progress-bar-success",
+			});
+
+			frm.dashboard.add_progress(__("Reposting Progress"), bars);
+		}
+
+		if (!frm.doc.vouchers_posted) {
+			return;
 		}
 
-		let progress = flt((cint(frm.doc.current_index) / total_count) * 100, 2) || 0.5;
-		var title = __("Reposting Completed {0}%", [progress]);
+		// Show voucher posting progress if vouchers are being reposted
+		bars = [];
+		progress = flt((cint(frm.doc.vouchers_posted) / cint(frm.doc.total_vouchers)) * 100, 2) || 0.5;
+		title = __("Reposting for Vouchers Completed {0}%", [progress]);
 
 		bars.push({
 			title: title,
 			width: progress + "%",
 			progress_class: "progress-bar-success",
 		});
 
-		frm.dashboard.add_progress(__("Reposting Progress"), bars);
+		frm.dashboard.add_progress(__("Reposting Vouchers Progress"), bars);
 	},
 
 	restart_reposting: function (frm) {

erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.json

@@ -27,14 +27,23 @@
   "error_section",
   "error_log",
   "reposting_info_section",
-  "reposting_data_file",
   "items_to_be_repost",
-  "distinct_item_and_warehouse",
   "column_break_o1sj",
   "total_reposting_count",
   "current_index",
   "gl_reposting_index",
-  "affected_transactions"
+  "vouchers_based_on_item_and_warehouse_section",
+  "total_vouchers",
+  "column_break_yqwo",
+  "vouchers_posted",
+  "last_sle_posted_section",
+  "reposted_item_code",
+  "reposted_warehouse",
+  "reposting_data_file",
+  "column_break_miwc",
+  "sle_posting_date",
+  "sle_posting_time",
+  "reposted_sle_creation"
  ],
  "fields": [
   {
@@ -167,15 +176,6 @@
    "print_hide": 1,
    "read_only": 1
   },
-  {
-   "fieldname": "distinct_item_and_warehouse",
-   "fieldtype": "Code",
-   "hidden": 1,
-   "label": "Distinct Item and Warehouse",
-   "no_copy": 1,
-   "print_hide": 1,
-   "read_only": 1
-  },
   {
    "fieldname": "current_index",
    "fieldtype": "Int",
@@ -185,14 +185,6 @@
    "print_hide": 1,
    "read_only": 1
   },
-  {
-   "fieldname": "affected_transactions",
-   "fieldtype": "Code",
-   "hidden": 1,
-   "label": "Affected Transactions",
-   "no_copy": 1,
-   "read_only": 1
-  },
   {
    "default": "0",
    "fieldname": "gl_reposting_index",
@@ -205,7 +197,7 @@
   {
    "fieldname": "reposting_info_section",
    "fieldtype": "Section Break",
-   "label": "Reposting Info"
+   "label": "Reposting Item and Warehouse"
   },
   {
    "fieldname": "column_break_o1sj",
@@ -214,14 +206,7 @@
   {
    "fieldname": "total_reposting_count",
    "fieldtype": "Int",
-   "label": "Total Reposting Count",
-   "no_copy": 1,
-   "read_only": 1
-  },
-  {
-   "fieldname": "reposting_data_file",
-   "fieldtype": "Attach",
-   "label": "Reposting Data File",
+   "label": "No of Items to Repost",
    "no_copy": 1,
    "read_only": 1
   },
@@ -247,13 +232,89 @@
    "fieldname": "repost_only_accounting_ledgers",
    "fieldtype": "Check",
    "label": "Repost Only Accounting Ledgers"
+  },
+  {
+   "fieldname": "vouchers_based_on_item_and_warehouse_section",
+   "fieldtype": "Section Break",
+   "label": "Reposting Vouchers"
+  },
+  {
+   "fieldname": "total_vouchers",
+   "fieldtype": "Int",
+   "label": "Total Ledgers",
+   "no_copy": 1,
+   "read_only": 1
+  },
+  {
+   "fieldname": "column_break_yqwo",
+   "fieldtype": "Column Break"
+  },
+  {
+   "fieldname": "vouchers_posted",
+   "fieldtype": "Int",
+   "label": "Ledgers Posted",
+   "no_copy": 1,
+   "read_only": 1
+  },
+  {
+   "fieldname": "last_sle_posted_section",
+   "fieldtype": "Section Break",
+   "label": "Last SLE Posted"
+  },
+  {
+   "fieldname": "reposted_item_code",
+   "fieldtype": "Link",
+   "label": "Reposted Item Code",
+   "no_copy": 1,
+   "options": "Item",
+   "read_only": 1
+  },
+  {
+   "fieldname": "reposted_warehouse",
+   "fieldtype": "Link",
+   "label": "Reposted Warehouse",
+   "no_copy": 1,
+   "options": "Warehouse",
+   "read_only": 1
+  },
+  {
+   "fieldname": "column_break_miwc",
+   "fieldtype": "Column Break"
+  },
+  {
+   "fieldname": "reposted_sle_creation",
+   "fieldtype": "Datetime",
+   "label": "Reposted SLE Creation",
+   "no_copy": 1,
+   "read_only": 1
+  },
+  {
+   "fieldname": "sle_posting_date",
+   "fieldtype": "Date",
+   "label": "SLE Posting Date",
+   "no_copy": 1,
+   "read_only": 1
+  },
+  {
+   "fieldname": "sle_posting_time",
+   "fieldtype": "Time",
+   "label": "SLE Posting Time",
+   "no_copy": 1,
+   "read_only": 1
+  },
+  {
+   "fieldname": "reposting_data_file",
+   "fieldtype": "Attach",
+   "label": "Reposting Data File",
+   "no_copy": 1,
+   "read_only": 1
   }
  ],
  "grid_page_length": 50,
  "index_web_pages_for_search": 1,
  "is_submittable": 1,
  "links": [],
- "modified": "2026-02-25 14:22:21.681549",
+ "modified": "2026-03-26 13:52:51.895504",
  "modified_by": "Administrator",
  "module": "Stock",
  "name": "Repost Item Valuation",

erpnext/stock/doctype/repost_item_valuation/repost_item_valuation.py

@@ -35,14 +35,12 @@ class RepostItemValuation(Document):
 	if TYPE_CHECKING:
 		from frappe.types import DF
 
-		affected_transactions: DF.Code | None
 		allow_negative_stock: DF.Check
 		allow_zero_rate: DF.Check
 		amended_from: DF.Link | None
 		based_on: DF.Literal["Transaction", "Item and Warehouse"]
 		company: DF.Link | None
 		current_index: DF.Int
-		distinct_item_and_warehouse: DF.Code | None
 		error_log: DF.LongText | None
 		gl_reposting_index: DF.Int
 		item_code: DF.Link | None
@@ -51,13 +49,20 @@ class RepostItemValuation(Document):
 		posting_time: DF.Time | None
 		recreate_stock_ledgers: DF.Check
 		repost_only_accounting_ledgers: DF.Check
+		reposted_item_code: DF.Link | None
+		reposted_sle_creation: DF.Datetime | None
+		reposted_warehouse: DF.Link | None
 		reposting_data_file: DF.Attach | None
 		reposting_reference: DF.Data | None
+		sle_posting_date: DF.Date | None
+		sle_posting_time: DF.Time | None
 		status: DF.Literal["Queued", "In Progress", "Completed", "Skipped", "Failed", "Cancelled"]
 		total_reposting_count: DF.Int
+		total_vouchers: DF.Int
 		via_landed_cost_voucher: DF.Check
 		voucher_no: DF.DynamicLink | None
 		voucher_type: DF.Link | None
+		vouchers_posted: DF.Int
 		warehouse: DF.Link | None
 	# end: auto-generated types
 
@@ -261,6 +266,13 @@ def restart_reposting(self):
 		self.items_to_be_repost = None
 		self.gl_reposting_index = 0
 		self.total_reposting_count = 0
+		self.total_vouchers = 0
+		self.vouchers_posted = 0
+		self.reposted_item_code = None
+		self.reposted_warehouse = None
+		self.sle_posting_date = None
+		self.sle_posting_time = None
+		self.reposted_sle_creation = None
 		self.clear_attachment()
 		self.db_update()
 
@@ -435,7 +447,7 @@ def repost_sl_entries(doc):
 		)
 	else:
 		repost_future_sle(
-			args=[
+			items_to_be_repost=[
 				frappe._dict(
 					{
 						"item_code": doc.item_code,

erpnext/stock/report/stock_ledger_variance/stock_ledger_variance.py

@@ -248,12 +248,7 @@ def get_item_warehouse_combinations(filters: dict | None = None) -> dict:
 			bin.warehouse,
 			item.valuation_method,
 		)
-		.where(
-			(item.is_stock_item == 1)
-			& (item.has_serial_no == 0)
-			& (warehouse.is_group == 0)
-			& (warehouse.company == filters.company)
-		)
+		.where((item.is_stock_item == 1) & (warehouse.is_group == 0) & (warehouse.company == filters.company))
 	)
 
 	if filters.item_code: