Skip to content

Commit 19a8ebe

Browse files
fix(payment_entry): convert the date args to string type before escaping in get_outstanding_reference_documents (backport #54639) (#54648)
Co-authored-by: diptanilsaha <diptanil@frappe.io> fix(payment_entry): convert the date args to string type before escaping in `get_outstanding_reference_documents` (#54639)
1 parent 6dbc17d commit 19a8ebe

1 file changed

Lines changed: 6 additions & 3 deletions

File tree

erpnext/accounts/doctype/payment_entry/payment_entry.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2328,16 +2328,19 @@ def get_outstanding_reference_documents(args, validate=False):
23282328
}
23292329

23302330
for fieldname, date_fields in date_fields_dict.items():
2331+
from_date = frappe.db.escape(str(args.get(date_fields[0]))) if args.get(date_fields[0]) else None
2332+
to_date = frappe.db.escape(str(args.get(date_fields[1]))) if args.get(date_fields[1]) else None
2333+
23312334
if args.get(date_fields[0]) and args.get(date_fields[1]):
2332-
condition += f" and {fieldname} between {frappe.db.escape(args.get(date_fields[0]))} and {frappe.db.escape(args.get(date_fields[1]))}"
2335+
condition += f" and {fieldname} between {from_date} and {to_date}"
23332336
posting_and_due_date.append(ple[fieldname][args.get(date_fields[0]) : args.get(date_fields[1])])
23342337
elif args.get(date_fields[0]):
23352338
# if only from date is supplied
2336-
condition += f" and {fieldname} >= {frappe.db.escape(args.get(date_fields[0]))}"
2339+
condition += f" and {fieldname} >= {from_date}"
23372340
posting_and_due_date.append(ple[fieldname].gte(args.get(date_fields[0])))
23382341
elif args.get(date_fields[1]):
23392342
# if only to date is supplied
2340-
condition += f" and {fieldname} <= {frappe.db.escape(args.get(date_fields[1]))}"
2343+
condition += f" and {fieldname} <= {to_date}"
23412344
posting_and_due_date.append(ple[fieldname].lte(args.get(date_fields[1])))
23422345

23432346
if args.get("company"):

0 commit comments

Comments
 (0)