Skip to content

Commit 1f78a9f

Browse files
authored
Merge pull request #52790 from frappe/mergify/bp/version-16/pr-52763
fix: better permissions on make payment request (backport #52763)
2 parents 372b011 + 78fc942 commit 1f78a9f

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

erpnext/accounts/doctype/payment_request/payment_request.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,9 @@ def make_payment_request(**args):
546546
if args.dn and not isinstance(args.dn, str):
547547
frappe.throw(_("Invalid parameter. 'dn' should be of type str"))
548548

549+
frappe.has_permission("Payment Request", "create", throw=True)
550+
frappe.has_permission(args.dt, "read", args.dn, throw=True)
551+
549552
ref_doc = args.ref_doc or frappe.get_doc(args.dt, args.dn)
550553
if not args.get("company"):
551554
args.company = ref_doc.company
@@ -819,7 +822,7 @@ def get_print_format_list(ref_doctype):
819822
return {"print_format": print_format_list}
820823

821824

822-
@frappe.whitelist(allow_guest=True)
825+
@frappe.whitelist()
823826
def resend_payment_email(docname):
824827
return frappe.get_doc("Payment Request", docname).send_email()
825828

0 commit comments

Comments
 (0)