Skip to content

Commit 62ea18f

Browse files
mihir-kandoimergify[bot]
authored andcommitted
fix: production plan status
(cherry picked from commit b3e6b30)
1 parent 302ae38 commit 62ea18f

1 file changed

Lines changed: 9 additions & 17 deletions

File tree

erpnext/manufacturing/doctype/production_plan/production_plan.py

Lines changed: 9 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -694,8 +694,8 @@ def set_status(self, close=None, update_bin=False):
694694
self.status = "Completed"
695695

696696
if self.status != "Completed":
697-
self.update_ordered_status()
698697
self.update_requested_status()
698+
self.update_ordered_status()
699699

700700
if close is not None:
701701
self.db_set("status", self.status)
@@ -704,25 +704,17 @@ def set_status(self, close=None, update_bin=False):
704704
self.update_bin_qty()
705705

706706
def update_ordered_status(self):
707-
update_status = False
708-
for d in self.po_items:
709-
if d.planned_qty == d.ordered_qty:
710-
update_status = True
711-
712-
if update_status and self.status != "Completed":
713-
self.status = "In Process"
707+
for child_table in ["po_items", "sub_assembly_items"]:
708+
for item in self.get(child_table):
709+
if item.ordered_qty:
710+
self.status = "In Process"
711+
return
714712

715713
def update_requested_status(self):
716-
if not self.mr_items:
717-
return
718-
719-
update_status = True
720714
for d in self.mr_items:
721-
if d.quantity != d.requested_qty:
722-
update_status = False
723-
724-
if update_status:
725-
self.status = "Material Requested"
715+
if d.requested_qty:
716+
self.status = "Material Requested"
717+
break
726718

727719
def get_production_items(self):
728720
item_dict = {}

0 commit comments

Comments
 (0)