fix: inventory dimension patch (backport #54147) (#54149)

Co-authored-by: Mihir Kandoi <kandoimihir@gmail.com>
fix: inventory dimension patch (#54147)

Author: mergify[bot]

erpnext/patches/v16_0/depends_on_inv_dimensions.py

@@ -16,26 +16,28 @@ def get_inventory_dimensions():
 	)
 
 
-def get_display_depends_on(doctype):
+def get_display_depends_on(doctype, fieldname):
 	if doctype not in [
 		"Stock Entry Detail",
 		"Sales Invoice Item",
 		"Delivery Note Item",
 		"Purchase Invoice Item",
 		"Purchase Receipt Item",
 	]:
-		return
+		return None, None
 
+	fieldname_start_with = "to"
 	display_depends_on = ""
 
 	if doctype in ["Purchase Invoice Item", "Purchase Receipt Item"]:
 		display_depends_on = "eval:parent.is_internal_supplier == 1"
+		fieldname_start_with = "from"
 	elif doctype != "Stock Entry Detail":
 		display_depends_on = "eval:parent.is_internal_customer == 1"
 	elif doctype == "Stock Entry Detail":
 		display_depends_on = "eval:doc.t_warehouse"
 
-	return display_depends_on
+	return f"{fieldname_start_with}_{fieldname}", display_depends_on
 
 
 def execute():
@@ -75,13 +77,13 @@ def execute():
 				"depends_on",
 				"eval:doc.t_warehouse",
 			)
-		if (display_depends_on := get_display_depends_on(dimension.doctype)) and frappe.db.exists(
-			"Custom Field",
-			{"fieldname": dimension.fieldname, "dt": dimension.doctype},
+		fieldname, display_depends_on = get_display_depends_on(dimension.doctype, dimension.fieldname)
+		if display_depends_on and frappe.db.exists(
+			"Custom Field", {"fieldname": fieldname, "dt": dimension.doctype}
 		):
 			frappe.set_value(
 				"Custom Field",
-				{"fieldname": dimension.fieldname, "dt": dimension.doctype},
+				{"fieldname": fieldname, "dt": dimension.doctype},
 				"mandatory_depends_on",
 				display_depends_on if dimension.reqd else dimension.mandatory_depends_on,
 			)