fix: remove unnecessary param, and use value from self

Author: vorasmit

erpnext/stock/doctype/stock_entry/stock_entry.py

@@ -342,9 +342,7 @@ def _set_serial_batch_for_disassembly_from_stock_entry(self):
 		scale_factor = flt(self.fg_completed_qty) / source_fg_qty if source_fg_qty else 0
 
 		bundle_data = get_voucher_wise_serial_batch_from_bundle(voucher_no=[self.source_stock_entry])
-		source_rows_by_name = {
-			r.name: r for r in self.get_items_from_manufacture_stock_entry(self.source_stock_entry)
-		}
+		source_rows_by_name = {r.name: r for r in self.get_items_from_manufacture_stock_entry()}
 
 		for row in self.items:
 			if not row.ste_detail:
@@ -2375,7 +2373,6 @@ def _add_items_for_disassembly_from_stock_entry(self):
 		self._append_disassembly_row_from_source(
 			disassemble_qty=disassemble_qty,
 			scale_factor=scale_factor,
-			source_stock_entry=self.source_stock_entry,
 		)
 
 	def _add_items_for_disassembly_from_work_order(self):
@@ -2396,8 +2393,8 @@ def _add_items_for_disassembly_from_work_order(self):
 			scale_factor=scale_factor,
 		)
 
-	def _append_disassembly_row_from_source(self, disassemble_qty, scale_factor, source_stock_entry=None):
-		for source_row in self.get_items_from_manufacture_stock_entry(self.source_stock_entry):
+	def _append_disassembly_row_from_source(self, disassemble_qty, scale_factor):
+		for source_row in self.get_items_from_manufacture_stock_entry():
 			if source_row.is_finished_item:
 				qty = disassemble_qty
 				s_warehouse = self.from_warehouse or source_row.t_warehouse
@@ -2433,10 +2430,10 @@ def _append_disassembly_row_from_source(self, disassemble_qty, scale_factor, sou
 				"use_serial_batch_fields": 1 if (source_row.batch_no or source_row.serial_no) else 0,
 			}
 
-			if source_stock_entry:
+			if self.source_stock_entry:
 				item.update(
 					{
-						"against_stock_entry": source_stock_entry,
+						"against_stock_entry": self.source_stock_entry,
 						"ste_detail": source_row.name,
 					}
 				)
@@ -2483,7 +2480,7 @@ def _add_items_for_disassembly_from_bom(self):
 		# Finished goods
 		self.load_items_from_bom()
 
-	def get_items_from_manufacture_stock_entry(self, stock_entry=None):
+	def get_items_from_manufacture_stock_entry(self):
 		SE = frappe.qb.DocType("Stock Entry")
 		SED = frappe.qb.DocType("Stock Entry Detail")
 		query = frappe.qb.from_(SED).join(SE).on(SED.parent == SE.name).where(SE.docstatus == 1)
@@ -2508,10 +2505,10 @@ def get_items_from_manufacture_stock_entry(self, stock_entry=None):
 			SED.bom_no,
 		]
 
-		if stock_entry:
+		if self.source_stock_entry:
 			return (
 				query.select(SED.name, SED.qty, SED.transfer_qty, *common_fields)
-				.where(SE.name == stock_entry)
+				.where(SE.name == self.source_stock_entry)
 				.orderby(SED.idx)
 				.run(as_dict=True)
 			)