Skip to content

Commit 9cfd704

Browse files
Pandiyan5273mihir-kandoi
authored andcommitted
fix(stock): update target field attribute
(cherry picked from commit 7e08154)
1 parent 29b3549 commit 9cfd704

2 files changed

Lines changed: 3 additions & 3 deletions

File tree

erpnext/stock/doctype/inventory_dimension/inventory_dimension.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ def set_source_and_target_fieldname(self) -> None:
138138
self.source_fieldname = scrub(self.dimension_name)
139139

140140
if not self.target_fieldname:
141-
self.target_fieldname = scrub(self.reference_document)
141+
self.target_fieldname = scrub(self.dimension_name)
142142

143143
def on_update(self):
144144
self.add_custom_fields()

erpnext/stock/doctype/inventory_dimension/test_inventory_dimension.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -118,12 +118,12 @@ def test_inventory_dimension(self):
118118
inward.load_from_db()
119119

120120
sle_data = frappe.db.get_value(
121-
"Stock Ledger Entry", {"voucher_no": inward.name}, ["shelf", "warehouse"], as_dict=1
121+
"Stock Ledger Entry", {"voucher_no": inward.name}, ["to_shelf", "warehouse"], as_dict=1
122122
)
123123

124124
self.assertEqual(inward.items[0].to_shelf, "Shelf 1")
125125
self.assertEqual(sle_data.warehouse, warehouse)
126-
self.assertEqual(sle_data.shelf, "Shelf 1")
126+
self.assertEqual(sle_data.to_shelf, "Shelf 1")
127127

128128
outward = make_stock_entry(
129129
item_code=item_code,

0 commit comments

Comments
 (0)