Skip to content

Commit 9ff924e

Browse files
Sudharsanan11mergify[bot]
authored andcommitted
fix(manufacturing): remove delete query of job card & batch and serial no (#52840)
* fix(manufacturing): remove delete query of batch and serial no * fix(manufacturing): remove delete query of job card * fix: remove delete function call for work order (cherry picked from commit 8b2a971)
1 parent 8437355 commit 9ff924e

2 files changed

Lines changed: 0 additions & 14 deletions

File tree

erpnext/manufacturing/doctype/routing/test_routing.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ def test_sequence_id(self):
5656
self.assertEqual(job_card_doc.total_completed_qty, 10)
5757

5858
wo_doc.cancel()
59-
wo_doc.delete()
6059

6160
def test_update_bom_operation_time(self):
6261
"""Update cost shouldn't update routing times."""

erpnext/manufacturing/doctype/work_order/work_order.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -780,7 +780,6 @@ def on_cancel(self):
780780
self.db_set("status", "Cancelled")
781781

782782
self.on_close_or_cancel()
783-
self.delete_job_card()
784783

785784
def on_close_or_cancel(self):
786785
if self.production_plan and frappe.db.exists(
@@ -794,7 +793,6 @@ def on_close_or_cancel(self):
794793
self.update_planned_qty()
795794
self.update_ordered_qty()
796795
self.update_reserved_qty_for_production()
797-
self.delete_auto_created_batch_and_serial_no()
798796

799797
if self.reserve_stock:
800798
self.update_stock_reservation()
@@ -926,13 +924,6 @@ def create_batch_for_finished_good(self):
926924
)
927925
)
928926

929-
def delete_auto_created_batch_and_serial_no(self):
930-
for row in frappe.get_all("Serial No", filters={"work_order": self.name}):
931-
frappe.delete_doc("Serial No", row.name)
932-
933-
for row in frappe.get_all("Batch", filters={"reference_name": self.name}):
934-
frappe.delete_doc("Batch", row.name)
935-
936927
def make_serial_nos(self, args):
937928
item_details = frappe.get_cached_value(
938929
"Item", self.production_item, ["serial_no_series", "item_name", "description"], as_dict=1
@@ -1384,10 +1375,6 @@ def set_lead_time(self):
13841375
if self.actual_start_date and self.actual_end_date:
13851376
self.lead_time = flt(time_diff_in_hours(self.actual_end_date, self.actual_start_date) * 60)
13861377

1387-
def delete_job_card(self):
1388-
for d in frappe.get_all("Job Card", ["name"], {"work_order": self.name}):
1389-
frappe.delete_doc("Job Card", d.name)
1390-
13911378
def validate_production_item(self):
13921379
if frappe.get_cached_value("Item", self.production_item, "has_variants"):
13931380
frappe.throw(_("Work Order cannot be raised against a Item Template"), ItemHasVariantError)

0 commit comments

Comments
 (0)