Skip to content

Commit a8f05ca

Browse files
Nishka Gosaliamergify[bot]
authored andcommitted
fix: enabling skip delivery option for order type maintenance
(cherry picked from commit 1a22e3c) # Conflicts: # erpnext/selling/doctype/sales_order/sales_order.json # erpnext/selling/doctype/sales_order/test_sales_order.py
1 parent 3cf10fa commit a8f05ca

2 files changed

Lines changed: 31 additions & 1 deletion

File tree

erpnext/selling/doctype/sales_order/sales_order.json

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1484,9 +1484,9 @@
14841484
},
14851485
{
14861486
"default": "0",
1487+
"depends_on": "eval:doc.order_type == 'Maintenance';",
14871488
"fieldname": "skip_delivery_note",
14881489
"fieldtype": "Check",
1489-
"hidden": 1,
14901490
"hide_days": 1,
14911491
"hide_seconds": 1,
14921492
"label": "Skip Delivery Note",
@@ -1671,7 +1671,11 @@
16711671
"idx": 105,
16721672
"is_submittable": 1,
16731673
"links": [],
1674+
<<<<<<< HEAD
16741675
"modified": "2025-07-28 12:14:29.760988",
1676+
=======
1677+
"modified": "2026-02-06 11:06:16.092658",
1678+
>>>>>>> 1a22e3cb61 (fix: enabling skip delivery option for order type maintenance)
16751679
"modified_by": "Administrator",
16761680
"module": "Selling",
16771681
"name": "Sales Order",

erpnext/selling/doctype/sales_order/test_sales_order.py

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,33 @@ def setUp(self):
5757
def tearDown(self):
5858
frappe.set_user("Administrator")
5959

60+
<<<<<<< HEAD
6061
@change_settings("Selling Settings", {"allow_negative_rates_for_items": 1})
62+
=======
63+
def test_sales_order_skip_delivery_note(self):
64+
so = make_sales_order(do_not_submit=True)
65+
so.order_type = "Maintenance"
66+
so.skip_delivery_note = 1
67+
so.append(
68+
"items",
69+
{
70+
"item_code": "_Test Item 2",
71+
"qty": 2,
72+
"rate": 100,
73+
},
74+
)
75+
so.save()
76+
so.submit()
77+
78+
so.reload()
79+
si = make_sales_invoice(so.name)
80+
si.insert()
81+
si.submit()
82+
so.reload()
83+
self.assertEqual(so.status, "Completed")
84+
85+
@IntegrationTestCase.change_settings("Selling Settings", {"allow_negative_rates_for_items": 1})
86+
>>>>>>> 1a22e3cb61 (fix: enabling skip delivery option for order type maintenance)
6187
def test_sales_order_with_negative_rate(self):
6288
"""
6389
Test if negative rate is allowed in Sales Order via doc submission and update items

0 commit comments

Comments
 (0)