Skip to content

Commit df6dc54

Browse files
authored
Merge pull request #54202 from frappe/mergify/bp/version-14/pr-54192
fix: added exception handling on service level agreement apply hook (#50096) (backport #54192)
2 parents 5bbfb79 + 12b2788 commit df6dc54

1 file changed

Lines changed: 10 additions & 4 deletions

File tree

erpnext/support/doctype/service_level_agreement/service_level_agreement.py

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -449,10 +449,16 @@ def get_documents_with_active_service_level_agreement():
449449

450450

451451
def set_documents_with_active_service_level_agreement():
452-
active = [
453-
sla.document_type for sla in frappe.get_all("Service Level Agreement", fields=["document_type"])
454-
]
455-
frappe.cache().hset("service_level_agreement", "active", active)
452+
try:
453+
active = frozenset(
454+
sla.document_type for sla in frappe.get_all("Service Level Agreement", fields=["document_type"])
455+
)
456+
frappe.cache().hset("service_level_agreement", "active", active)
457+
except (frappe.DoesNotExistError, frappe.db.TableMissingError):
458+
# This happens during install / uninstall when wildcard hook for SLA intercepts some doc action.
459+
# In both cases, the error can be safely ignored.
460+
active = frozenset()
461+
456462
return active
457463

458464

0 commit comments

Comments
 (0)