fix: bypass pagination in download_results to prevent truncated exports (#1096) (#1097)

Author: mergify[bot]

insights/insights/doctype/insights_data_source_v3/ibis_utils.py

@@ -776,13 +776,14 @@ def execute_ibis_query(
     query: IbisQuery,
     page=1,
     page_size=100,
+    paginate=True,
     force=False,
     cache=True,
     cache_expiry=3600,
     reference_doctype=None,
     reference_name=None,
 ):
-    if hasattr(query, "limit"):
+    if paginate and hasattr(query, "limit"):
         page_size = clamp(page_size, 1, 10_000)
         page = clamp(page, 1, 10_000)
         offset = (page - 1) * page_size

insights/insights/doctype/insights_query_v3/insights_query_v3.py

@@ -238,10 +238,13 @@ def download_results(
         if decimal_casts:
             ibis_query = ibis_query.mutate(**decimal_casts)
 
+        if hasattr(ibis_query, "limit"):
+            ibis_query = ibis_query.limit(100_000)
+
         results, _ = execute_ibis_query(
             ibis_query,
             cache=False,
-            page_size=10_00_000,
+            paginate=False,
             reference_doctype=self.doctype,
             reference_name=self.name,
         )