chore: run linter; use just-has package

Author: freakyfelt

.eslintrc.json

@@ -0,0 +1,26 @@
+{
+    "env": {
+        "browser": true,
+        "es2021": true
+    },
+    "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "prettier"
+    ],
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "ecmaVersion": "latest",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint"
+    ],
+    "rules": {
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": ["warn", {
+            "argsIgnorePattern": "^_",
+            "varsIgnorePattern": "^_"
+        }]
+    }
+}

lib/__fixtures__/statements.ts

@@ -86,6 +86,7 @@ export const InvalidConstraintStatement = parsePolicyStatement(
   {
     action: "create",
     effect: "allow",
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     constraint: { foo: "bar" } as any,
   },
   "InvalidConstraintStatement"

lib/parsed-policy-statement.ts

@@ -1,6 +1,6 @@
-import { PolicyStatement } from "./types";
 import { RulesLogic } from "json-logic-js";
 import { randomUUID } from "node:crypto";
+import { PolicyStatement } from "./types";
 import { traverseRulesLogic } from "./utils/logic";
 import {
   isStringLiteral,

lib/policy-resolver.ts

@@ -1,14 +1,13 @@
-import jsonLogic, { RulesLogic } from "json-logic-js";
+import jsonLogic from "json-logic-js";
+import pathExists from "just-has";
 import { PolicyStatementStore } from "./store/types";
 import { JsonLogicParser, PolicyDocument, PolicyStatement } from "./types";
 import {
   ParsedPolicyStatement,
   parsePolicyStatement,
 } from "./parsed-policy-statement";
-import { pathExists } from "./utils/obj";
 import { PolicyDocumentValidator } from "./validator";
 import { CachedStatementsStore } from "./store/cached-statements-store";
-import { IndexedStatementsStore } from "./store/indexed-statements-store";
 
 interface ResourceActionResolverOptions {
   parser?: JsonLogicParser;
@@ -27,7 +26,7 @@ function hasAllPaths(statement: ParsedPolicyStatement, ctx: unknown) {
     return false;
   }
   return statement.contextPaths.every((path) =>
-    pathExists(ctx as Record<string, unknown>, path)
+    pathExists(ctx, path)
   );
 }
 
@@ -78,7 +77,7 @@ export class PolicyResolver {
       this.#cache.set(action, this.#compileAction(action));
     }
 
-    return this.#cache.get(action)!.can(context);
+    return this.#cache.get(action)?.can(context) ?? false;
   }
 
   /**
@@ -94,7 +93,7 @@ export class PolicyResolver {
       this.#cache.set(action, this.#compileAction(action));
     }
 
-    return this.#cache.get(action)!.explain(context);
+    return this.#cache.get(action)?.explain(context) ?? [];
   }
 
   #compileAction<TContext>(action: string): CompiledFns<TContext> {

lib/store/cached-statements-store.ts

@@ -41,7 +41,7 @@ export class CachedStatementsStore implements PolicyStatementStore {
       );
     }
 
-    return this.#cache.get(action)!.map((sid) => this.#mustGet(sid));
+    return this.#cache.get(action)?.map((sid) => this.#mustGet(sid)) ?? [];
   }
 
   #mustGet(sid: string): ParsedPolicyStatement {

lib/store/index.ts

@@ -0,0 +1,3 @@
+export * from "./cached-statements-store";
+export * from "./indexed-statements-store";
+export * from "./types";

lib/store/indexed-statements-store.test.ts

@@ -5,7 +5,6 @@ import {
   GlobStartStatement,
   MultipleActionsStatement,
 } from "../__fixtures__/statements";
-import { parsePolicyStatement } from "../parsed-policy-statement";
 import { IndexedStatementsStore } from "./indexed-statements-store";
 
 describe("IndexedStatementsStore", () => {

lib/store/indexed-statements-store.ts

@@ -1,11 +1,5 @@
 import assert from "node:assert";
-import { PolicyStatement } from "../types";
-import {
-  ParsedPolicyStatement,
-  parsePolicyStatement,
-  SYM_SID,
-} from "../parsed-policy-statement";
-import { disjoint } from "../utils/arr";
+import { ParsedPolicyStatement, SYM_SID } from "../parsed-policy-statement";
 import {
   ParsedStatementsDB,
   ByActionIndex,
@@ -68,6 +62,7 @@ export class IndexedStatementsStore implements PolicyStatementStore {
     const statementIds = [...this.#byAction.globAll];
 
     if (this.#byAction.exact.has(action)) {
+      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
       statementIds.push(...this.#byAction.exact.get(action)!);
     }
     for (const [regexp, sid] of this.#byAction.regex) {

lib/store/types.ts

@@ -1,5 +1,4 @@
 import { ParsedPolicyStatement } from "../parsed-policy-statement";
-import { PolicyStatement } from "../types";
 
 export type ParsedStatementsDB = Map<string, ParsedPolicyStatement>;