Commit 1f21974
committed
Fix lift helper crash on model-level pydantic errors
`_navigable_path` unpacked `*prefix, leaf = loc` and crashed on
empty loc tuples, which pydantic emits for `@model_validator`
errors. Return early with no path components instead.
Also fix `test_lift_handles_nested_conditional_drift` to not
inherit the BASE_TOOL `shell_command` reference to `inputs.msg`,
since the test's conditional-only input set doesn't declare it
and the `_check_input_refs_and_outputs` validator (added after
the test) now rejects it.1 parent 78c8858 commit 1f21974
2 files changed
Lines changed: 3 additions & 0 deletions
File tree
- lib/galaxy/tool_util_models
- test/unit/tool_util_models
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
| 282 | + | |
| 283 | + | |
282 | 284 | | |
283 | 285 | | |
284 | 286 | | |
| |||
Lines changed: 1 addition & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
86 | 86 | | |
87 | 87 | | |
88 | 88 | | |
| 89 | + | |
89 | 90 | | |
90 | 91 | | |
91 | 92 | | |
| |||
0 commit comments