LazyToolBox: drop the broken to_panel_view override

The override I had ignored the ``view`` argument entirely and just
flattened ``_tool_index.entries`` by ``panel_section_id``, so any
caller hitting ``GET /api/tool_panels/<view>`` with a custom view got
the whole tool registry's sections back instead of the requested view.

``test_panel_views::test_custom_label_order`` configures
``default_panel_view = "my-custom"`` whose definition is just
labels + tools, asserts the response has zero sections, and got back
the global ``test_section_multi`` and similar — because the override
walked every index entry without consulting the named view.

Remove the override entirely. The parent ``AbstractToolBox.to_panel_view``
calls ``tool_panel_contents(trans, view=view)`` which in turn invokes
the registered ``ToolPanelView.apply_view`` for the named view; that's
the correct behaviour for both ``default``, ``edam:*``, and the
``StaticToolPanelView`` instances built from ``panel_views`` /
``panel_views_dir``. With the prior commit that defers
``_load_tool_panel_views`` until after the index is populated, the
parent path renders correctly under LazyToolBox.

Local: ``test_panel_views::test_custom_label_order`` now PASSES.

Author: mvdbeek

lib/galaxy/tools/lazy_toolbox.py

@@ -1515,46 +1515,3 @@ def _index_entry_to_api_dict(self, entry: ToolIndexEntry) -> dict[str, Any]:
             "target": "galaxy_main",
         }
 
-    def to_panel_view(self, trans, view="default_panel_view", **kwds) -> dict[str, dict]:
-        """
-        Create a panel view representation of the toolbox.
-
-        For LazyToolBox, returns tools from index organized by section.
-        """
-        if self._tool_index is None:
-            return {}
-
-        view_contents: dict[str, dict] = {}
-
-        # Group tools by section from index
-        sections: dict[str, dict[str, Any]] = {}
-        uncategorized_tools: list[dict[str, Any]] = []
-
-        for _tool_id, entry in self._tool_index.entries.items():
-            if entry.hidden and not kwds.get("include_hidden", False):
-                continue
-
-            tool_dict = self._index_entry_to_api_dict(entry)
-
-            section_id = entry.panel_section_id
-            if section_id:
-                if section_id not in sections:
-                    sections[section_id] = {
-                        "id": section_id,
-                        "name": entry.panel_section_name or section_id,
-                        "model_class": "ToolSection",
-                        "elems": [],
-                    }
-                sections[section_id]["elems"].append(tool_dict)
-            else:
-                uncategorized_tools.append(tool_dict)
-
-        # Add sections to view_contents
-        for section_id, section_dict in sections.items():
-            view_contents[section_id] = section_dict
-
-        # Add uncategorized tools directly
-        for tool_dict in uncategorized_tools:
-            view_contents[tool_dict["id"]] = tool_dict
-
-        return view_contents