Fix purging datasets whose total_size is None.

Fix the error:

Removing disk, file  /opt/galaxy/database/files/000/dataset_192.dat
Error attempting to purge data file:  /opt/galaxy/database/files/000/dataset_192.dat  error:  unsupported operand type(s) for -=: 'Decimal' and 'NoneType'

when running:

python scripts/cleanup_datasets/cleanup_datasets.py config/galaxy.ini -d 10 -3 -r

Author: nsoranzo

lib/galaxy/model/__init__.py

@@ -1434,13 +1434,11 @@ def set_size( self ):
     def get_total_size( self ):
         if self.total_size is not None:
             return self.total_size
-        if self.file_size:
-            # for backwards compatibility, set if unset
-            self.set_total_size()
-            db_session = object_session( self )
-            db_session.flush()
-            return self.total_size
-        return 0
+        # for backwards compatibility, set if unset
+        self.set_total_size()
+        db_session = object_session( self )
+        db_session.flush()
+        return self.total_size
     def set_total_size( self ):
         if self.file_size is None:
             self.set_size()

scripts/cleanup_datasets/cleanup_datasets.py

@@ -465,7 +465,7 @@ def _purge_dataset( app, dataset, remove_from_disk, info_only = False ):
                                 if hda.history.user is not None and hda.history.user not in usage_users:
                                     usage_users.append( hda.history.user )
                         for user in usage_users:
-                            user.total_disk_usage -= dataset.total_size
+                            user.total_disk_usage -= dataset.get_total_size()
                             app.sa_session.add( user )
                     print "Purging dataset id", dataset.id
                     dataset.purged = True