Attempt to increase testing scope

Author: guerler

test/unit/data/model/test_model.py

@@ -86,18 +86,44 @@ def test_implicit_collection_jobs_serialize_orphan_associations():
     assert rval["jobs"] == [42]
 
 
-def test_get_identifier_for_id_null_handling():
-    """Null job-param ids raise in strict mode and pass through in
-    tolerate_missing_data mode."""
+def test_job_serialize_with_null_param_ids():
+    """Driving Job._serialize end-to-end with a JobParameter that contains
+    {"src": "hda", "id": null}: strict mode raises, tolerate_missing_data
+    mode produces a serialized dict whose params preserve the null ref."""
+    import datetime
+    import json
+
+    job = model.Job()
+    job.id = 42
+    job.tool_id = "cat1"
+    job.tool_version = "1.0"
+    job.galaxy_version = "test"
+    job.state = "ok"
+    job.info = None
+    job.traceback = None
+    job.command_line = None
+    job.tool_stderr = None
+    job.job_stderr = None
+    job.tool_stdout = None
+    job.job_stdout = None
+    job.exit_code = 0
+    job.create_time = datetime.datetime(2026, 1, 1)
+    job.update_time = datetime.datetime(2026, 1, 1)
+    job.job_messages = None
+    job.object_store_id = None
+    job.object_store_id_overrides = None
+    job.parameters = [model.JobParameter(name="input1", value=json.dumps({"src": "hda", "id": None}))]
+
     strict = model.SerializationOptions(for_edit=True)
     try:
-        strict.get_identifier_for_id(id_encoder=None, obj_id=None)
+        job._serialize(id_encoder=None, serialization_options=strict)
     except NotImplementedError:
         pass
     else:
-        raise AssertionError("strict mode should have raised on null obj_id")
+        raise AssertionError("strict mode should have raised on null param id")
 
     tolerant = model.SerializationOptions(for_edit=True, tolerate_missing_data=True)
-    assert tolerant.get_identifier_for_id(id_encoder=None, obj_id=None) is None
-    assert tolerant.get_identifier_for_id(id_encoder=None, obj_id=0) == 0
-    assert tolerant.get_identifier_for_id(id_encoder=None, obj_id=42) == 42
+    rval = job._serialize(id_encoder=None, serialization_options=tolerant)
+    assert rval["params"]["input1"] == {"src": "hda", "id": None}
+    assert rval["id"] == 42
+    assert rval["tool_id"] == "cat1"