Begin to handle dataset details in dataset display component

Author: guerler

client/src/components/Dataset/DatasetDisplay.vue

@@ -1,10 +1,13 @@
 <script setup lang="ts">
 import axios from "axios";
 import { onMounted, ref } from "vue";
+
 import { withPrefix } from "@/utils/redirect";
 
 import TabularChunkedView from "components/Visualizations/Tabular/TabularChunkedView.vue";
 
+const MAX_PEEK_SIZE_BINARY = 100000;
+
 interface Props {
     datasetId: string;
     isPreview: boolean;
@@ -14,7 +17,6 @@ const props = withDefaults(defineProps<Props>(), {});
 
 const content = ref();
 const datasetDetails = ref();
-const deleted = ref(true);
 
 onMounted(async () => {
     const detailsUrl = withPrefix(`/api/datasets/${props.datasetId}`);
@@ -36,8 +38,8 @@ onMounted(async () => {
 </script>
 
 <template>
-    <div>
-        <div v-if="deleted" class="errormessagelarge" id="deleted-data-message">
+    <div v-if="datasetDetails">
+        <div v-if="datasetDetails.deleted" id="deleted-data-message" class="errormessagelarge">
             You are viewing a deleted dataset.
         </div>
         <div class="warningmessagelarge">
@@ -47,15 +49,15 @@ onMounted(async () => {
         </div>
         <div class="warningmessagelarge">
             This is a binary (or unknown to Galaxy) dataset of size ${ file_size }. Preview is not implemented for this filetype. Displaying
-            %if truncated:
-        first 100KB
-            %endif
-        as ASCII text<br/>
+            <span v-if="datasetDetails.file_size > MAX_PEEK_SIZE_BINARY">
+                first 100KB
+            </span>
+            as ASCII text<br/>
             <a href="${h.url_for( controller='dataset', action='display', dataset_id=trans.security.encode_id( data.id ), to_ext=data.ext )}">Download</a>
         </div>
-        <TabularChunkedView v-if="content" :options="{ dataset_config: { ...datasetDetails, first_data_chunk: content } }" />
-        <pre>
-            {{  content }}
+        <TabularChunkedView v-if="content && content.ck_data" :options="{ dataset_config: { ...datasetDetails, first_data_chunk: content } }" />
+        <pre v-else>
+            {{ content }}
         </pre>
     </div>
 </template>

client/src/components/Dataset/DatasetView.vue

@@ -13,13 +13,13 @@ import { bytesToString } from "@/utils/utils";
 import DatasetError from "../DatasetInformation/DatasetError.vue";
 import LoadingSpan from "../LoadingSpan.vue";
 import DatasetAsImage from "./DatasetAsImage/DatasetAsImage.vue";
+import DatasetDisplay from "./DatasetDisplay.vue";
 import DatasetState from "./DatasetState.vue";
 import Heading from "@/components/Common/Heading.vue";
 import DatasetAttributes from "@/components/DatasetInformation/DatasetAttributes.vue";
 import DatasetDetails from "@/components/DatasetInformation/DatasetDetails.vue";
 import VisualizationsList from "@/components/Visualizations/Index.vue";
 import VisualizationFrame from "@/components/Visualizations/VisualizationFrame.vue";
-import DatasetDisplay from "./DatasetDisplay.vue";
 
 const datasetStore = useDatasetStore();
 const datatypeStore = useDatatypeStore();
@@ -202,7 +202,7 @@ watch(
                 class="p-3" />
             <DatasetDisplay
                 v-else
-                :datasetId="datasetId"
+                :dataset-id="datasetId"
                 :is-preview="true"
                 @load="iframeLoading = false" />
         </div>
@@ -219,7 +219,7 @@ watch(
             </div>
             <DatasetDisplay
                 v-else
-                :datasetId="datasetId"
+                :dataset-id="datasetId"
                 :is-preview="true"
                 @load="iframeLoading = false" />
         </div>

lib/galaxy/datatypes/data.py

@@ -602,9 +602,8 @@ def display_data(
         else:  # displaying
             trans.log_event(f"Display dataset id: {str(dataset.id)}")
             max_peek_size = _get_max_peek_size(dataset)
-            if (
-                _is_binary_file(dataset) and preview and hasattr(trans, "fill_template_mako")
-            ):  # preview file which format is unknown (to Galaxy), we still try to display this as text
+            if _is_binary_file(dataset) and preview:
+                # preview file which format is unknown (to Galaxy), we still try to display this as text
                 return self._serve_binary_file_contents_as_text(trans, dataset, headers, file_size, max_peek_size)
             else:  # text/html, or image, or display was called without preview flag
                 return self._serve_file_contents(trans, dataset, headers, preview, file_size, max_peek_size)