Use DataItemSourceType, fix linting

Author: guerler

lib/galaxy/managers/history_graph.py

@@ -43,6 +43,7 @@
     HistoryGraphResponse,
     TruncationInfo,
 )
+from galaxy.schema.schema import DataItemSourceType
 from galaxy.security.idencoding import IdEncodingHelper
 from galaxy.structured_app import MinimalManagerApp
 from galaxy.tool_util.toolbox import AbstractToolBox
@@ -413,9 +414,9 @@ def visit(path, key, value):
                     parent = parent[step]
                 if isinstance(parent, dict):
                     src = parent.get("src")
-                    if src == "hda":
+                    if src == DataItemSourceType.hda:
                         refs.add(("dataset", value))
-                    elif src == "hdca":
+                    elif src == DataItemSourceType.hdca:
                         refs.add(("collection", value))
             return key, value
 

test/unit/app/managers/test_HistoryGraphBuilder.py

@@ -35,7 +35,7 @@ def set_up_managers(self):
         self.hda_manager = self.app[HDAManager]
         self.history_manager = self.app[HistoryManager]
         self.collection_manager = self.app[DatasetCollectionManager]
-        self.app._toolbox = None  # type: ignore[assignment]
+        self.app._toolbox = None
         self.history_graph_manager = self.app[HistoryGraphManager]
 
     def _build_graph(
@@ -1177,7 +1177,7 @@ def set_up_managers(self):
         self.hda_manager = self.app[HDAManager]
         self.history_manager = self.app[HistoryManager]
         self.collection_manager = self.app[DatasetCollectionManager]
-        self.app._toolbox = None  # type: ignore[assignment]
+        self.app._toolbox = None
         self.history_graph_manager = self.app[HistoryGraphManager]
 
     def _build_graph(self, history, **kwargs):