Make requester_email required and requester_name optional, filled server-side

Both fields are now populated from the authenticated user on the backend
(trans.user.email / trans.user.username) rather than from the form payload,
preventing spoofing. requester_email is always present for registered users;
requester_name is optional since usernames are not always set.

- ToolRequestNotificationContent: swap required/optional for the two fields
- NotificationCard: always render email, conditionally prepend name
- Email templates: same conditional rendering logic
- schema.ts: regenerated to match

Author: arash77

client/src/api/notifications.ts

@@ -37,8 +37,8 @@ export interface ToolRequestNotificationContent {
     requested_version?: string;
     conda_available?: boolean;
     test_data_available?: boolean;
-    requester_name: string;
-    requester_email?: string;
+    requester_name?: string;
+    requester_email: string;
     requester_affiliation?: string;
 }
 

client/src/api/schema/schema.ts

@@ -23737,12 +23737,12 @@ export interface components {
              * Requester email
              * @description The email address of the requester for follow-up.
              */
-            requester_email?: string | null;
+            requester_email: string;
             /**
              * Requester name
              * @description The name of the person requesting the tool.
              */
-            requester_name: string;
+            requester_name?: string | null;
             /**
              * Scientific domain
              * @description The scientific domain for the requested tool.

client/src/components/Notifications/NotificationCard.vue

@@ -204,21 +204,19 @@ function markNotificationAsSeen() {
                         <dt>Version</dt>
                         <dd>{{ props.notification.content.requested_version }}</dd>
                     </template>
-                    <template v-if="props.notification.content.requester_name">
-                        <dt>Requested by</dt>
-                        <dd>
+                    <dt>Requested by</dt>
+                    <dd>
+                        <span v-if="props.notification.content.requester_name">
                             {{ props.notification.content.requester_name }}
                             <span v-if="props.notification.content.requester_affiliation">
                                 ({{ props.notification.content.requester_affiliation }})
                             </span>
-                            <span v-if="props.notification.content.requester_email">
-                                &mdash;
-                                <BLink :href="`mailto:${props.notification.content.requester_email}`">
-                                    {{ props.notification.content.requester_email }}
-                                </BLink>
-                            </span>
-                        </dd>
-                    </template>
+                            &mdash;
+                        </span>
+                        <BLink :href="`mailto:${props.notification.content.requester_email}`">
+                            {{ props.notification.content.requester_email }}
+                        </BLink>
+                    </dd>
                 </dl>
             </template>
             <template v-else>

lib/galaxy/config/templates/mail/notifications/tool_request-email.html

@@ -96,9 +96,7 @@
       <tr>
         <td style="padding: 4px 8px; font-weight: bold; white-space: nowrap;">Requested by</td>
         <td style="padding: 4px 8px;">
-          {{ content['requester_name'] }}
-          {% if content['requester_affiliation'] %} ({{ content['requester_affiliation'] }}){% endif %}
-          {% if content['requester_email'] %} &mdash; {{ content['requester_email'] }}{% endif %}
+          {% if content['requester_name'] %}{{ content['requester_name'] }} &mdash; {% endif %}{{ content['requester_email'] }}{% if content['requester_affiliation'] %} ({{ content['requester_affiliation'] }}){% endif %}
         </td>
       </tr>
     </table>

lib/galaxy/config/templates/mail/notifications/tool_request-email.txt

@@ -45,7 +45,7 @@ Tool name:    {{ content['tool_name'] }}
 {% endif %}{% if content['conda_available'] is not none %}Conda pkg:    {{ "Yes" if content['conda_available'] else "No" }}
 {% endif %}{% if content['test_data_available'] is not none %}Test data:    {{ "Yes" if content['test_data_available'] else "No" }}
 {% endif %}{% if content['workflow_name'] %}Workflow:     {{ content['workflow_name'] }}
-{% endif %}Requested by: {{ content['requester_name'] }}{% if content['requester_affiliation'] %} ({{ content['requester_affiliation'] }}){% endif %}{% if content['requester_email'] %} — {{ content['requester_email'] }}{% endif %}
+{% endif %}Requested by: {% if content['requester_name'] %}{{ content['requester_name'] }} — {% endif %}{{ content['requester_email'] }}{% if content['requester_affiliation'] %} ({{ content['requester_affiliation'] }}){% endif %}
 
 {% if galaxy_url %}
 You can review the notification in Galaxy: {{ galaxy_url }}/user/notifications

lib/galaxy/schema/notifications.py

@@ -137,9 +137,11 @@ class ToolRequestNotificationContent(Model):
     test_data_available: Optional[bool] = Field(
         None, title="Test data available", description="Whether test data for this tool is available."
     )
-    requester_name: str = Field(..., title="Requester name", description="The name of the person requesting the tool.")
-    requester_email: Optional[str] = Field(
-        None, title="Requester email", description="The email address of the requester for follow-up."
+    requester_name: Optional[str] = Field(
+        None, title="Requester name", description="The name of the person requesting the tool."
+    )
+    requester_email: str = Field(
+        ..., title="Requester email", description="The email address of the requester for follow-up."
     )
     requester_affiliation: Optional[str] = Field(
         None, title="Requester affiliation", description="The affiliation/lab of the requester."