Skip to content

Commit 721e3c9

Browse files
committed
fix: render tool_url as plain text in notification card
Avoid rendering the URL as a clickable link to prevent admin-targeted URL injection attacks where a malicious user crafts a misleading href.
1 parent 10982ef commit 721e3c9

1 file changed

Lines changed: 1 addition & 4 deletions

File tree

client/src/components/Notifications/NotificationCard.vue

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,7 @@ function markNotificationAsSeen() {
193193
<template v-if="props.notification.content.tool_url">
194194
<dt>URL</dt>
195195
<dd>
196-
<BLink :href="props.notification.content.tool_url" target="_blank">
197-
{{ props.notification.content.tool_url }}
198-
<FontAwesomeIcon :icon="faExternalLinkAlt" fixed-width size="sm" />
199-
</BLink>
196+
<span class="text-break">{{ props.notification.content.tool_url }}</span>
200197
</dd>
201198
</template>
202199
<template v-if="props.notification.content.scientific_domain">

0 commit comments

Comments
 (0)