Skip to content

Commit 73d9731

Browse files
committed
Use pnpm publish for galaxy-client and strip workspace-only postinstall
The client/ package.json now has @galaxyproject/galaxy-api-client at workspace:* and a postinstall that filters into the workspace to build it. npm publish doesn't rewrite the workspace: protocol, so the published tarball would carry the literal "workspace:*" and break downstream installs; pnpm publish substitutes the real version. The postinstall is also workspace-only -- if it ships in the tarball, consumers' npm install fails when pnpm --filter runs outside any workspace -- so npm pkg delete strips it before pnpm publish runs.
1 parent f7f2827 commit 73d9731

1 file changed

Lines changed: 5 additions & 1 deletion

File tree

.github/workflows/publish_artifacts.yaml

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,11 @@ jobs:
121121
working-directory: 'client'
122122
- name: publish client
123123
if: (github.event_name == 'workflow_dispatch' && inputs.release_type == 'release') || (github.event_name == 'release' && !github.event.release.prerelease)
124-
run: npm publish --provenance --access public
124+
# `pnpm publish` rewrites `workspace:*` deps to real versions; `npm publish` would ship the literal protocol and break downstream installs.
125+
# Strip the workspace-only `postinstall` so it doesn't run in consumers' node_modules.
126+
run: |
127+
npm pkg delete scripts.postinstall
128+
pnpm publish --provenance --access public --no-git-checks
125129
working-directory: 'client'
126130
- name: sync client-api version
127131
run: npm run sync-version

0 commit comments

Comments
 (0)