Resolve hidden lineage versions via toolbox version map

tool_cache is keyed by the unversioned tool id, so looking up a
lineage version via tool_cache.get_tool_by_id("tool/0.1") always
returned None and hidden_tool_versions came back empty. Look up
each lineage version through toolbox._tool_versions_by_id, which
is keyed exactly that way (tool_id -> {version: Tool}).

Author: mvdbeek

lib/galaxy/tools/__init__.py

@@ -1127,11 +1127,12 @@ def tool_versions(self):
     def hidden_tool_versions(self):
         if not self.lineage:
             return []
+        versions_by_id = self.app.toolbox._tool_versions_by_id.get(self.id, {})
         hidden_versions = []
-        for lineage_version in self.lineage.get_versions():
-            tool = self.app.tool_cache.get_tool_by_id(lineage_version.id)
+        for version in self.lineage.tool_versions:
+            tool = versions_by_id.get(version)
             if tool and tool.hidden:
-                hidden_versions.append(tool.version)
+                hidden_versions.append(version)
         return hidden_versions
 
     @property