Fix Vue 3 / VTU v2 patterns in tests and stores

- historyStore: replace Vue 2 set()/del() with direct property
  assignment / delete operator. del() was undefined and threw at
  runtime in tests.
- Test files: replace wrapper.destroy() with wrapper.unmount() for
  Vue Test Utils v2.
- Test files: add explicit describe/it/expect imports where missing
  (vitest globals are disabled).

Addresses ~30 of the remaining test failures (delete operator, VTU v2
unmount API, missing vitest globals). Heading slot rendering and
BootstrapVue compat-mode issues still account for the bulk of the
remaining failures.

Author: dannon

client/src/components/Common/PersistentTaskProgressMonitorAlert.test.ts

@@ -1,5 +1,5 @@
 import { shallowMount } from "@vue/test-utils";
-import { vi } from "vitest";
+import { beforeEach, describe, expect, it, vi } from "vitest";
 import { ref } from "vue";
 
 import type { TaskMonitor } from "@/composables/genericTaskMonitor";

client/src/components/Common/RenameModal.test.ts

@@ -75,7 +75,7 @@ describe("RenameModal tested for renaming workflows", () => {
         expect(wrapper.emitted("close")).toBeTruthy();
 
         // Simulate parent closing and reopening the modal (destroys old instance)
-        wrapper.destroy();
+        wrapper.unmount();
         await mountRenameModal();
         expect((createWrapper(document.body).find("#workflow-name-input").element as HTMLInputElement).value).toBe(
             WORKFLOW_NAME,

client/src/components/Common/VegaWrapper.test.ts

@@ -63,7 +63,7 @@ describe("VegaWrapper", () => {
             propsData: { spec: defaultSpec },
         });
         await flushPromises();
-        wrapper.destroy();
+        wrapper.unmount();
 
         expect(mockFinalize).toHaveBeenCalled();
     });

client/src/components/ConfirmDialog.test.ts

@@ -16,7 +16,7 @@ describe("ConfirmDialog", () => {
 
     afterEach(() => {
         setConfirmDialogComponentRef(null);
-        wrapper.destroy();
+        wrapper.unmount();
         document.body.innerHTML = "";
     });
 

client/src/components/Form/Elements/FormData/FormData.test.ts

@@ -4,6 +4,7 @@ import "@/composables/__mocks__/filter";
 import { createTestingPinia } from "@pinia/testing";
 import { dispatchEvent, getLocalVue } from "@tests/vitest/helpers";
 import { mount } from "@vue/test-utils";
+import { describe, expect, it } from "vitest";
 
 import { testDatatypesMapper } from "@/components/Datatypes/test_fixtures";
 import { useDatatypesMapperStore } from "@/stores/datatypesMapperStore";

client/src/components/Form/Elements/FormNumber.test.js

@@ -22,12 +22,12 @@ describe("FormNumber", () => {
         const wrapperFloat = await mountFormNumber({ value: 1, type: "float" });
         const inputFloat = await getInput(wrapperFloat);
         expect(inputFloat.exists()).toBe(true);
-        wrapperFloat.destroy();
+        wrapperFloat.unmount();
 
         const wrapperInteger = await mountFormNumber({ value: 1, type: "integer" });
         const inputInteger = await getInput(wrapperInteger);
         expect(inputInteger.exists()).toBe(true);
-        wrapperInteger.destroy();
+        wrapperInteger.unmount();
     });
 
     it("renders a range input only when both min and max are defined and max > min", async () => {
@@ -114,7 +114,7 @@ describe("FormNumber", () => {
         });
 
         expect(preventDefaultInteger).toHaveBeenCalled();
-        integerWrapper.destroy();
+        integerWrapper.unmount();
     });
 
     it("allows '.' for float type", async () => {
@@ -128,7 +128,7 @@ describe("FormNumber", () => {
         });
 
         expect(preventDefaultFloat).not.toHaveBeenCalled();
-        floatWrapper.destroy();
+        floatWrapper.unmount();
     });
 
     it("allows typing '-' when negative numbers are permitted", async () => {
@@ -143,7 +143,7 @@ describe("FormNumber", () => {
         });
 
         expect(preventDefault).not.toHaveBeenCalled();
-        wrapper.destroy();
+        wrapper.unmount();
     });
 
     it("blocks typing '-' when min is non-negative", async () => {
@@ -158,7 +158,7 @@ describe("FormNumber", () => {
         });
 
         expect(preventDefault).toHaveBeenCalled();
-        wrapper.destroy();
+        wrapper.unmount();
     });
 
     it("computes the correct step value based on float precision", async () => {

client/src/components/Form/Elements/FormSelectMany/FormSelectMany.test.ts

@@ -3,6 +3,7 @@ import "./worker/__mocks__/selectMany";
 import { createTestingPinia } from "@pinia/testing";
 import { getLocalVue } from "@tests/vitest/helpers";
 import { mount } from "@vue/test-utils";
+import { describe, expect, it } from "vitest";
 
 import type { SelectOption } from "./worker/selectMany";
 

client/src/components/ObjectStore/ObjectStoreBadge.test.ts

@@ -1,5 +1,6 @@
 import { getLocalVue } from "@tests/vitest/helpers";
 import { mount, type Wrapper } from "@vue/test-utils";
+import { describe, expect, it } from "vitest";
 
 import type { ObjectStoreBadgeType } from "@/api/objectStores.templates";
 import { MESSAGES } from "@/components/ObjectStore/badgeMessages";

client/src/components/Panels/Common/Tool.test.ts

@@ -71,6 +71,6 @@ describe("Tool", () => {
         (favoriteButton.element as HTMLElement).focus();
         expect(document.activeElement).toBe(favoriteButton.element);
 
-        wrapper.destroy();
+        wrapper.unmount();
     });
 });

client/src/composables/accessibleHover.test.ts

@@ -49,7 +49,7 @@ describe("useAccessibleHover", () => {
         await advanceTooltipHoverDelay();
         expect(onEnter).toHaveBeenCalledTimes(1);
 
-        wrapper.destroy();
+        wrapper.unmount();
     });
 
     test("cancels delayed hover enter on mouseleave", async () => {
@@ -68,7 +68,7 @@ describe("useAccessibleHover", () => {
         expect(onEnter).not.toHaveBeenCalled();
         expect(onExit).not.toHaveBeenCalled();
 
-        wrapper.destroy();
+        wrapper.unmount();
     });
 
     test("shows immediately on focus", () => {
@@ -81,6 +81,6 @@ describe("useAccessibleHover", () => {
         element.dispatchEvent(new Event("focus"));
         expect(onEnter).toHaveBeenCalledTimes(1);
 
-        wrapper.destroy();
+        wrapper.unmount();
     });
 });