Skip to content

Commit 78454fc

Browse files
authored
Merge pull request #684 from jmchilton/doc_opt_improvements
Conda/Container documentation and option naming improvements.
2 parents 45d5256 + f81c529 commit 78454fc

4 files changed

Lines changed: 12 additions & 8 deletions

File tree

docs/_writing_dependencies_conda.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -259,7 +259,7 @@ all the software and all the versions available matching that search term - incl
259259

260260
Alternatively the Anaconda_ website can be used to search for packages. Typing ``seqtk``
261261
into the search form on that page and clicking the top result will bring on to `this page
262-
https://anaconda.org/bioconda/seqtk`__ with information about the Bioconda package.
262+
<https://anaconda.org/bioconda/seqtk>`__ with information about the Bioconda package.
263263

264264
When using the website to search though, you need to aware of what channel you are using. By
265265
default, Planemo and Galaxy will search a few different Conda channels. While it is possible

docs/_writing_dependencies_docker.rst

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ tool from the introductory tutorial.
4747

4848
::
4949

50-
$ planemo lint --biocontainer seqtk_xml
50+
$ planemo lint --biocontainers seqtk_seq.xml
5151
Linting tool /home/planemo/workspace/planemo/project_templates/seqtk_complete/seqtk_seq.xml
5252
Applying linter tests... CHECK
5353
.. CHECK: 1 test(s) found.
@@ -79,11 +79,11 @@ BioConda_ recipes are packaged into containers and registered on quay.io_
7979
as part of the BioContainers_ project.
8080

8181
This tool can be tested using ``planemo test`` in its BioContainer
82-
Docker container using the flag ``--mulled_containers`` as shown (in part) next.
82+
Docker container using the flag ``--biocontainers`` as shown (in part) next.
8383

8484
::
8585

86-
$ planemo test --mulled_containers seqtk_seq.xml
86+
$ planemo test --biocontainers seqtk_seq.xml
8787
...
8888
2017-03-01 08:18:19,669 INFO [galaxy.tools.actions] Handled output named output1 for tool seqtk_seq (22.145 ms)
8989
2017-03-01 08:18:19,683 INFO [galaxy.tools.actions] Added output datasets to history (14.604 ms)
@@ -123,7 +123,7 @@ This line indicates that Galaxy was able to find a container for this tool and
123123
executed the tool in that container.
124124

125125
For interactive testing, the ``planemo serve`` command also implements the
126-
``--mulled_containers`` flag.
126+
``--biocontainers`` flag.
127127

128128
In this seqtk example the relevant BioContainer already existed on quay.io_,
129129
this won't always be the case. For tools that contain multiple ``requirement``
@@ -247,11 +247,11 @@ Docker command ``images`` and explore the new container interactively with
247247
/usr/local/bin/bwa
248248

249249
As before, we can test running the tool inside its container in Galaxy using
250-
the ``--mulled_containers`` flag.
250+
the ``--biocontainers`` flag.
251251

252252
::
253253

254-
$ planemo test --mulled_containers bwa_and_samtools.xml
254+
$ planemo test --biocontainers bwa_and_samtools.xml
255255
...
256256
2017-03-01 10:20:58,077 INFO [galaxy.tools.actions] Handled output named output_2 for tool bwa_and_samtools (17.443 ms)
257257
2017-03-01 10:20:58,090 INFO [galaxy.tools.actions] Added output datasets to history (12.935 ms)
@@ -305,7 +305,7 @@ Planemo doesn't yet expose options that make it possible to build mulled
305305
containers for local packages that have yet to be published to anaconda.org
306306
but the mulled toolkit allows this. See mulled_ documentation for more
307307
information. However, once a container for a local package is built with
308-
``mulled-build-tool`` the ``--mulled_containers`` command should work to test
308+
``mulled-build-tool`` the ``--biocontainers`` command should work to test
309309
it.
310310

311311
----------------------------------------------------------------

planemo/commands/cmd_lint.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,9 @@
3434
help="Check tool requirements for availability in best practice Conda channels.",
3535
)
3636
@click.option(
37+
"biocontainer",
3738
"--biocontainer",
39+
"--biocontainers",
3840
is_flag=True,
3941
default=False,
4042
help="Check best practice BioContainer namespaces for a container definition applicable for this tool.",

planemo/options.py

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -343,7 +343,9 @@ def job_config_option():
343343

344344
def mulled_containers_option():
345345
return planemo_option(
346+
"mulled_containers",
346347
"--mulled_containers",
348+
"--biocontainers",
347349
is_flag=True,
348350
help="Test tools against mulled containers (forces --docker).",
349351
)

0 commit comments

Comments
 (0)