Skip to content

Commit d9519bc

Browse files
authored
Merge pull request #882 from jmchilton/remove_galaxy_paths
remove unused, problematic galaxy_paths var collections in testing...
2 parents f9465ac + 9b8562d commit d9519bc

1 file changed

Lines changed: 2 additions & 22 deletions

File tree

planemo/galaxy/activity.py

Lines changed: 2 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ def _execute(ctx, config, runnable, job_path, **kwds):
7575

7676
history_id = _history_id(user_gi, **kwds)
7777

78-
galaxy_paths, job_dict, _ = stage_in(ctx, runnable, config, user_gi, history_id, job_path, **kwds)
78+
job_dict, _ = stage_in(ctx, runnable, config, user_gi, history_id, job_path, **kwds)
7979

8080
if runnable.type in [RunnableType.galaxy_tool, RunnableType.cwl_tool]:
8181
response_class = GalaxyToolRunResponse
@@ -163,7 +163,6 @@ def _execute(ctx, config, runnable, job_path, **kwds):
163163
runnable=runnable,
164164
user_gi=user_gi,
165165
history_id=history_id,
166-
galaxy_paths=galaxy_paths,
167166
log=log_contents_str(config),
168167
**response_kwds
169168
)
@@ -281,19 +280,7 @@ def create_collection_func(element_identifiers, collection_type):
281280
f.write(log_contents_str(config))
282281
raise Exception(msg)
283282

284-
galaxy_paths = []
285-
for (dataset, upload_target) in datasets:
286-
if isinstance(upload_target, FileUploadTarget):
287-
local_path = upload_target.path
288-
ctx.vlog("fetching full dataset for %s, %s" % (dataset, local_path))
289-
dataset_full = user_gi.datasets.show_dataset(dataset["id"])
290-
galaxy_path = dataset_full["file_name"]
291-
ctx.vlog("galaxy_path is %s" % galaxy_path)
292-
job_path = os.path.join(job_dir, local_path)
293-
galaxy_paths.append((job_path, galaxy_path))
294-
295-
ctx.vlog("galaxy_paths are %s" % galaxy_paths)
296-
return galaxy_paths, job_dict, datasets
283+
return job_dict, datasets
297284

298285

299286
class GalaxyBaseRunResponse(SuccessfulRunResponse):
@@ -304,7 +291,6 @@ def __init__(
304291
runnable,
305292
user_gi,
306293
history_id,
307-
galaxy_paths,
308294
log,
309295
):
310296
self._ctx = ctx
@@ -315,8 +301,6 @@ def __init__(
315301

316302
self._job_info = None
317303

318-
self.galaxy_paths = galaxy_paths
319-
320304
self._outputs_dict = None
321305

322306
def to_galaxy_output(self, output):
@@ -467,7 +451,6 @@ def __init__(
467451
runnable,
468452
user_gi,
469453
history_id,
470-
galaxy_paths,
471454
log,
472455
job_info,
473456
api_run_response,
@@ -477,7 +460,6 @@ def __init__(
477460
runnable=runnable,
478461
user_gi=user_gi,
479462
history_id=history_id,
480-
galaxy_paths=galaxy_paths,
481463
log=log,
482464
)
483465
self._job_info = job_info
@@ -513,7 +495,6 @@ def __init__(
513495
runnable,
514496
user_gi,
515497
history_id,
516-
galaxy_paths,
517498
log,
518499
workflow_id,
519500
invocation_id,
@@ -523,7 +504,6 @@ def __init__(
523504
runnable=runnable,
524505
user_gi=user_gi,
525506
history_id=history_id,
526-
galaxy_paths=galaxy_paths,
527507
log=log,
528508
)
529509
self._workflow_id = workflow_id

0 commit comments

Comments
 (0)