Skip to content

clean up namespace usage. Fix for CID 1054792#285

Merged
luizirber merged 4 commits intomasterfrom
fixes/CID_1054792
Feb 12, 2014
Merged

clean up namespace usage. Fix for CID 1054792#285
luizirber merged 4 commits intomasterfrom
fixes/CID_1054792

Conversation

@mr-c
Copy link
Copy Markdown
Contributor

@mr-c mr-c commented Feb 3, 2014

This should satisfy #179 CID 1054792 (Medium) Uninitialized scalar field (UNINIT_CTOR)

@luizirber or @camillescott, please review

  • Is it mergable
  • Did it pass the tests?
  • If it introduce new functionality in scripts/ is it tested? Check for code coverage
  • Is it well formatted? Look at pep8/pylint and cppcheck output. Use autopep8 and astyle -A10 if needed.
  • Is it documented in the Changelog?

@ged-jenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/174/

@ged-jenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/175/

@ged-jenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/177/

@ged-jenkins
Copy link
Copy Markdown

Test FAILed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/183/

Comment thread ChangeLog Outdated
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FIXME

@ged-jenkins
Copy link
Copy Markdown

Test PASSed.
Refer to this link for build results: http://ci.ged.msu.edu/job/khmer-multi-pullrequest/192/

luizirber added a commit that referenced this pull request Feb 12, 2014
clean up namespace usage. Fix for CID 1054792
@luizirber luizirber merged commit 99a960c into master Feb 12, 2014
@luizirber luizirber deleted the fixes/CID_1054792 branch February 12, 2014 23:05
@mr-c
Copy link
Copy Markdown
Contributor Author

mr-c commented Feb 12, 2014

Thanks!

On Wed, Feb 12, 2014 at 6:05 PM, Luiz Irber notifications@github.comwrote:

Merged #285 #285.

Reply to this email directly or view it on GitHubhttps://github.com//pull/285
.

luizirber added a commit that referenced this pull request Apr 1, 2014
clean up namespace usage. Fix for CID 1054792
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants