Skip to content

Commit 2919ee1

Browse files
committed
Remove deprecated PG::BasicTypeRegistry.register_type and co.
Freezing DEFAULT_TYPE_REGISTRY is necessary to make BasicTypeMap* available in Ractor. This breaks PG::BasicTypeRegistry.register_type and co. but they have been deprecated since pg-1.3.0.
1 parent fff2484 commit 2919ee1

2 files changed

Lines changed: 0 additions & 42 deletions

File tree

lib/pg/basic_type_registry.rb

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -294,14 +294,4 @@ def register_default_types
294294

295295
# @private
296296
DEFAULT_TYPE_REGISTRY = PG.make_shareable(PG::BasicTypeRegistry.new.register_default_types)
297-
298-
# Delegate class method calls to DEFAULT_TYPE_REGISTRY
299-
class << self
300-
%i[ register_coder register_type alias_type ].each do |meth|
301-
define_method(meth) do |*args|
302-
warn "PG::BasicTypeRegistry.#{meth} is deprecated. Please use your own instance by PG::BasicTypeRegistry.new instead!"
303-
DEFAULT_TYPE_REGISTRY.send(meth, *args)
304-
end
305-
end
306-
end
307297
end

spec/pg/basic_type_registry_spec.rb

Lines changed: 0 additions & 32 deletions
Original file line numberDiff line numberDiff line change
@@ -62,37 +62,5 @@
6262
expect{ regi.coders_for 0, :coder }.to raise_error( ArgumentError )
6363
expect{ regi.coders_for 2, :encoder }.to raise_error( ArgumentError )
6464
end
65-
66-
context "class methods" do
67-
let!(:regi){ PG::BasicTypeRegistry::DEFAULT_TYPE_REGISTRY }
68-
69-
it "can register_type" do
70-
expect do
71-
PG::BasicTypeRegistry.register_type(1, 'testtype1', PG::BinaryEncoder::Int8, PG::BinaryDecoder::Integer)
72-
end.to output(/deprecated/).to_stderr
73-
74-
expect( regi.coders_for(1, :encoder)['testtype1'] ).to be_kind_of(PG::BinaryEncoder::Int8)
75-
expect( regi.coders_for(1, :decoder)['testtype1'] ).to be_kind_of(PG::BinaryDecoder::Integer)
76-
end
77-
78-
it "can alias_type" do
79-
expect do
80-
PG::BasicTypeRegistry.alias_type(1, 'testtype2', 'int4')
81-
end.to output(/deprecated/).to_stderr
82-
83-
expect( regi.coders_for(1, :encoder)['testtype2'] ).to be_kind_of(PG::BinaryEncoder::Int4)
84-
expect( regi.coders_for(1, :decoder)['testtype2'] ).to be_kind_of(PG::BinaryDecoder::Integer)
85-
end
86-
87-
it "can register_coder" do
88-
enco = PG::BinaryEncoder::Int8.new(name: 'testtype3')
89-
expect do
90-
PG::BasicTypeRegistry.register_coder(enco)
91-
end.to output(/deprecated/).to_stderr
92-
93-
expect( regi.coders_for(1, :encoder)['testtype3'] ).to be(enco)
94-
expect( regi.coders_for(1, :decoder)['testtype3'] ).to be_nil
95-
end
96-
end
9765
end
9866
end

0 commit comments

Comments
 (0)