Skip to content

Consider using rb_yield_values instead of rb_yield_splat #54

@ged

Description

@ged

Original report by Anonymous.


On line 2178 of pg.c, rb_yield_splat is used in combination with rb_ary_new3 (http://bitbucket.org/ged/ruby-pg/src/eb0d4b1df418/ext/pg.c#cl-2178).

Wouldn't changing line 2178 to be:

rb_yield_values(3, relname, be_pid, extra);

make sense? It should be functionally equivalent and faster. Also, rb_yield_splat isn't supported by rubinius 1.1.1.

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions