Skip to content

Commit 830a798

Browse files
authored
[Route53Resolver] Fix missing Id filter support for list_resolver_query_log_configs (#9756)
1 parent 8030a04 commit 830a798

2 files changed

Lines changed: 27 additions & 0 deletions

File tree

moto/route53resolver/models.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -349,6 +349,7 @@ class ResolverQueryLogConfig(BaseModel):
349349
MAX_QUERY_LOG_CONFIGS_PER_REGION = 100
350350

351351
FILTER_NAMES = [
352+
"id",
352353
"name",
353354
"creator_request_id",
354355
"destination_arn",

tests/test_route53resolver/test_route53resolver.py

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -211,6 +211,32 @@ def test_list_resolver_query_log_configs_with_filters():
211211
assert response["ResolverQueryLogConfigs"][0]["Name"] == "production-logs"
212212

213213

214+
@mock_aws
215+
def test_list_resolver_query_log_configs_filter_by_id():
216+
client = boto3.client("route53resolver", region_name="us-east-1")
217+
218+
config1 = client.create_resolver_query_log_config(
219+
Name="first-logs",
220+
DestinationArn="arn:aws:s3:::first-bucket",
221+
CreatorRequestId="first-request-id",
222+
)
223+
config1_id = config1["ResolverQueryLogConfig"]["Id"]
224+
225+
client.create_resolver_query_log_config(
226+
Name="second-logs",
227+
DestinationArn="arn:aws:s3:::second-bucket",
228+
CreatorRequestId="second-request-id",
229+
)
230+
231+
response = client.list_resolver_query_log_configs(
232+
Filters=[{"Name": "Id", "Values": [config1_id]}]
233+
)
234+
235+
assert len(response["ResolverQueryLogConfigs"]) == 1
236+
assert response["ResolverQueryLogConfigs"][0]["Id"] == config1_id
237+
assert response["ResolverQueryLogConfigs"][0]["Name"] == "first-logs"
238+
239+
214240
@mock_aws
215241
def test_list_resolver_query_log_configs_empty():
216242
client = boto3.client("route53resolver", region_name="us-east-1")

0 commit comments

Comments
 (0)