feat: Set cf values to request headers for local debugging#35
Merged
gja merged 3 commits intogja:masterfrom Jul 26, 2019
Merged
feat: Set cf values to request headers for local debugging#35gja merged 3 commits intogja:masterfrom
gja merged 3 commits intogja:masterfrom
Conversation
Owner
|
Hi, thanks for the PR. I notice a that most of the tests are failing. Could you please update the PR with the tests fixed? Here is an example of the failing test: https://dev.azure.com/tejas0372/tejas/_build/results?buildId=68 |
gja
requested changes
Jul 11, 2019
gja
changed the title
Owner
|
Hi. Sorry for the late response. I've been a bit sick. Could you do the following
I'll merge in the PR post that. Thanks for the contribution! Excited to have this merged soon. |
Contributor
Author
|
Hi @gja, sorry for the bit of delay from me! Updated the PR to include a new test and also readme. Hope it makes the functionality more clear. Let me know if any other changes are needed. |
gja
approved these changes
Jul 26, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #34