Merge pull request #92 from gnpaone/sync-action

Sync source repo

Author: github-actions[bot]

src/analyzer.rs

@@ -234,11 +234,12 @@ impl<'run, 'src> Analyzer<'run, 'src> {
           parameter: parameter.name.lexeme(),
         }));
       }
+
       parameters.insert(parameter.name.lexeme());
 
       if parameter.default.is_some() {
         passed_default = true;
-      } else if passed_default {
+      } else if passed_default && parameter.is_required() {
         return Err(
           parameter
             .name

src/parameter.rs

@@ -13,6 +13,12 @@ pub(crate) struct Parameter<'src> {
   pub(crate) name: Name<'src>,
 }
 
+impl Parameter<'_> {
+  pub(crate) fn is_required(&self) -> bool {
+    self.default.is_none() && self.kind != ParameterKind::Star
+  }
+}
+
 impl ColorDisplay for Parameter<'_> {
   fn fmt(&self, f: &mut Formatter, color: Color) -> fmt::Result {
     if let Some(prefix) = self.kind.prefix() {

tests/parameters.rs

@@ -36,3 +36,17 @@ fn parameter_default_values_may_not_use_later_parameters() {
     .status(EXIT_FAILURE)
     .run();
 }
+
+#[test]
+fn star_may_follow_default() {
+  Test::new()
+    .justfile(
+      "
+        foo bar='baz' *bob:
+          @echo {{bar}} {{bob}}
+      ",
+    )
+    .args(["foo", "hello", "goodbye"])
+    .stdout("hello goodbye\n")
+    .run();
+}