Skip to content

fix(firestore): Move createIndexes calls#9714

Merged
bhshkh merged 4 commits intogoogleapis:mainfrom
bhshkh:fix/issue-9039
Apr 16, 2024
Merged

fix(firestore): Move createIndexes calls#9714
bhshkh merged 4 commits intogoogleapis:mainfrom
bhshkh:fix/issue-9039

Conversation

@bhshkh
Copy link
Copy Markdown
Contributor

@bhshkh bhshkh commented Apr 5, 2024

Fixes #9039

Issue: createIndexes is a setup step that is executed before running any of the tests. It is failing intermittently with context deadline exceeded error

Cause: Index creation takes too long

Fix:

  1. Create lesser number of indexes
  2. Move index creation to the tests that use those indexes so that rest of the tests can run even if the index creation fails
  3. Set higher context deadline

@bhshkh bhshkh requested review from a team April 5, 2024 19:31
@product-auto-label product-auto-label Bot added the api: firestore Issues related to the Firestore API. label Apr 5, 2024
@bhshkh
Copy link
Copy Markdown
Contributor Author

bhshkh commented Apr 5, 2024

Do not merge until release freeze ends mid April

@bhshkh bhshkh added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 5, 2024
@bhshkh bhshkh mentioned this pull request Apr 5, 2024
@bhshkh bhshkh removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Apr 15, 2024
@bhshkh bhshkh enabled auto-merge (squash) April 15, 2024 19:03
@bhshkh bhshkh merged commit d931626 into googleapis:main Apr 16, 2024
@bhshkh bhshkh deleted the fix/issue-9039 branch April 16, 2024 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: firestore Issues related to the Firestore API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

firestore: Failure failed

2 participants