fix(deps): update dependency @google-cloud/common to ^0.23.0 (#198)

* fix(deps): update dependency @google-cloud/common to ^0.23.0

* chore: specify `requestModule`

* chore: run `gts fix`

* chore: make `request` a non-dev dependency

Author: renovate[bot]

handwritten/package.json

@@ -54,10 +54,11 @@
     "license-check": "jsgl --local ."
   },
   "dependencies": {
-    "@google-cloud/common": "^0.21.0",
+    "@google-cloud/common": "^0.23.0",
     "console-log-level": "^1.4.0",
     "is": "^3.2.1",
-    "lodash.has": "^4.5.2"
+    "lodash.has": "^4.5.2",
+    "request": "^2.88.0"
   },
   "devDependencies": {
     "@google-cloud/nodejs-repo-tools": "^2.3.0",
@@ -87,7 +88,7 @@
     "@types/once": "^1.4.0",
     "@types/pify": "^3.0.2",
     "@types/proxyquire": "^1.3.28",
-    "@types/request": "^2.47.0",
+    "@types/request": "^2.47.1",
     "@types/restify": "^7.2.0",
     "@types/rimraf": "^2.0.2",
     "@types/tmp": "0.0.33",
@@ -129,7 +130,6 @@
     "power-assert": "^1.5.0",
     "prettier": "^1.12.1",
     "proxyquire": "^2.0.1",
-    "request": "^2.86.0",
     "restify": "^7.2.0",
     "rimraf": "^2.6.2",
     "source-map-support": "^0.5.6",

handwritten/src/google-apis/auth-client.ts

@@ -20,6 +20,7 @@ import {Configuration, Logger} from '../configuration';
 import {ErrorMessage} from '../classes/error-message';
 import * as http from 'http';
 import {Service, ServiceOptions} from '@google-cloud/common';
+import * as request from 'request';
 
 /* @const {Array<String>} list of scopes needed to work with the errors api. */
 const SCOPES = ['https://www.googleapis.com/auth/cloud-platform'];
@@ -99,6 +100,7 @@ export class RequestHandler extends Service {
     });
     super(
         {
+          requestModule: request,
           packageJson: pkg,
           baseUrl: API,
           scopes: SCOPES,

handwritten/system-test/error-reporting.ts

@@ -23,8 +23,8 @@ import {ErrorMessage} from '../src/classes/error-message';
 import {RequestHandler} from '../src/google-apis/auth-client';
 import {createLogger} from '../src/logger';
 import {FakeConfiguration as Configuration} from '../test/fixtures/configuration';
-import {ErrorGroupStats, ErrorsApiTransport} from '../utils/errors-api-transport';
 import {deepStrictEqual} from '../test/util';
+import {ErrorGroupStats, ErrorsApiTransport} from '../utils/errors-api-transport';
 
 import assign = require('lodash.assign');
 import pick = require('lodash.pick');

handwritten/test/unit/classes/error-message.ts

@@ -26,8 +26,7 @@ describe('Instantiating a new ErrorMessage', () => {
   });
 
   it('Should have a default service context', () => {
-    deepStrictEqual(
-        em.serviceContext, {service: 'node', version: undefined});
+    deepStrictEqual(em.serviceContext, {service: 'node', version: undefined});
   });
   it('Should have a default message', () => {
     assert.strictEqual(em.message, '');

handwritten/test/util.ts

@@ -19,6 +19,7 @@ import * as stringify from 'json-stable-stringify';
 
 export type Anything = {}|undefined|null;
 
-export function deepStrictEqual(actual: Anything, expected: Anything, message?: string) {
+export function deepStrictEqual(
+    actual: Anything, expected: Anything, message?: string) {
   assert.deepStrictEqual(stringify(actual), stringify(expected), message);
 }