Skip to content

Commit 1bacfaf

Browse files
yoshi-automationJustinBeckwith
authored andcommitted
fix: throw on invalid credentials (#548)
1 parent 88b7512 commit 1bacfaf

2 files changed

Lines changed: 13 additions & 9 deletions

File tree

handwritten/firestore/dev/src/v1/firestore_client.js

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -178,10 +178,14 @@ class FirestoreClient {
178178
];
179179
for (const methodName of firestoreStubMethods) {
180180
this._innerApiCalls[methodName] = gax.createApiCall(
181-
firestoreStub.then(stub => function() {
182-
const args = Array.prototype.slice.call(arguments, 0);
183-
return stub[methodName].apply(stub, args);
184-
}),
181+
firestoreStub.then(
182+
stub => function() {
183+
const args = Array.prototype.slice.call(arguments, 0);
184+
return stub[methodName].apply(stub, args);
185+
},
186+
err => function() {
187+
throw err;
188+
}),
185189
defaults[methodName],
186190
this._descriptors.page[methodName] ||
187191
this._descriptors.stream[methodName]);

handwritten/firestore/synth.metadata

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,19 +1,19 @@
11
{
2-
"updateTime": "2019-02-05T12:11:58.402Z",
2+
"updateTime": "2019-02-13T12:15:47.405884Z",
33
"sources": [
44
{
55
"generator": {
66
"name": "artman",
7-
"version": "0.16.9",
8-
"dockerImage": "googleapis/artman@sha256:80c39fa84e7203c8f355e01bdeef82155013cc39dcaa48fba7a6fe2c253623e3"
7+
"version": "0.16.13",
8+
"dockerImage": "googleapis/artman@sha256:5fd9aee1d82a00cebf425c8fa431f5457539562f5867ad9c54370f0ec9a7ccaa"
99
}
1010
},
1111
{
1212
"git": {
1313
"name": "googleapis",
1414
"remote": "https://github.com/googleapis/googleapis.git",
15-
"sha": "f26c727dde5051abefc5ad9e7dee82a2686ad2b0",
16-
"internalRef": "232306662"
15+
"sha": "ca61898878f0926dd9dcc68ba90764f17133efe4",
16+
"internalRef": "233680013"
1717
}
1818
},
1919
{

0 commit comments

Comments
 (0)