Skip to content

Commit 2d2f1e5

Browse files
callmehiphopJustinBeckwith
authored andcommitted
fix(deps): remove teeny-request as dependency (#199)
1 parent 6bf8f65 commit 2d2f1e5

4 files changed

Lines changed: 4 additions & 12 deletions

File tree

packages/google-cloud-resourcemanager/package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -45,8 +45,7 @@
4545
"dependencies": {
4646
"@google-cloud/common": "^0.32.0",
4747
"@google-cloud/paginator": "^0.2.0",
48-
"@google-cloud/promisify": "^0.4.0",
49-
"teeny-request": "^3.6.0"
48+
"@google-cloud/promisify": "^0.4.0"
5049
},
5150
"devDependencies": {
5251
"@google-cloud/nodejs-repo-tools": "^3.0.0",

packages/google-cloud-resourcemanager/src/index.ts

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,6 @@ import {GoogleAuthOptions, Operation, Service} from '@google-cloud/common';
1818
import {paginator} from '@google-cloud/paginator';
1919
import {promisifyAll} from '@google-cloud/promisify';
2020
import * as r from 'request'; // Only for type declarations.
21-
import {teenyRequest} from 'teeny-request';
2221

2322
import {Project} from './project';
2423

@@ -144,8 +143,7 @@ class Resource extends Service {
144143
baseUrl: 'https://cloudresourcemanager.googleapis.com/v1',
145144
scopes: ['https://www.googleapis.com/auth/cloud-platform'],
146145
projectIdRequired: false,
147-
packageJson: require('../../package.json'),
148-
requestModule: teenyRequest as typeof r,
146+
packageJson: require('../../package.json')
149147
};
150148
super(config, options);
151149

@@ -384,8 +382,7 @@ class Resource extends Service {
384382
if (!name) {
385383
throw new Error('A name must be specified for an operation.');
386384
}
387-
return new Operation<Project>(
388-
{parent: this, id: name, requestModule: teenyRequest as typeof r});
385+
return new Operation<Project>({parent: this, id: name});
389386
}
390387

391388
/**

packages/google-cloud-resourcemanager/src/project.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import {Operation, ServiceObject, util} from '@google-cloud/common';
1818
import {promisifyAll} from '@google-cloud/promisify';
1919
import * as r from 'request'; // Only for type declarations.
20-
import {teenyRequest} from 'teeny-request';
2120

2221
import {CreateProjectCallback, CreateProjectResponse, Resource} from '.';
2322

@@ -265,7 +264,6 @@ class Project extends ServiceObject {
265264

266265
super({
267266
parent: resource,
268-
requestModule: teenyRequest as typeof r,
269267
baseUrl: '/projects',
270268
/**
271269
* @name Project#id

packages/google-cloud-resourcemanager/test/index.ts

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,6 @@ import * as arrify from 'arrify';
2020
import * as assert from 'assert';
2121
import * as proxyquire from 'proxyquire';
2222
import {Response} from 'request';
23-
import {teenyRequest} from 'teeny-request';
2423

2524
import * as root from '../src';
2625
import {Project} from '../src';
@@ -353,8 +352,7 @@ describe('Resource', () => {
353352
const operation = resource.operation(NAME);
354353
assert(operation instanceof FakeOperation);
355354
assert.deepStrictEqual(
356-
operation.calledWith_[0],
357-
{parent: resource, id: NAME, requestModule: teenyRequest});
355+
operation.calledWith_[0], {parent: resource, id: NAME});
358356
});
359357
});
360358

0 commit comments

Comments
 (0)