Skip to content

Commit 2d97d68

Browse files
authored
test: refactors system test deleteDatasets() (#754)
* tests(system): adds check for creationTime * refactor: replaces parsInt with Number * test: refactor system test before hook * test(refactor): checks dataset existence before attempting deletion * chore: fix lint * refactor: deleteDatasets
1 parent 5a4ef62 commit 2d97d68

1 file changed

Lines changed: 13 additions & 11 deletions

File tree

handwritten/bigquery/system-test/bigquery.ts

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1698,16 +1698,18 @@ describe('BigQuery', () => {
16981698
filter: `labels.${GCLOUD_TESTS_PREFIX}`,
16991699
});
17001700

1701-
const deleteDatasetPromises = datasets
1702-
.filter(async dataset => {
1703-
const [metadata] = await dataset.getMetadata();
1704-
const creationTime = Number(metadata.creationTime);
1705-
return creationTime && isResourceStale(creationTime);
1706-
})
1707-
.map(dataset => {
1708-
return dataset.delete({force: true});
1709-
});
1710-
1711-
await Promise.all(deleteDatasetPromises);
1701+
for (const dataset of datasets) {
1702+
const [metadata] = await dataset.getMetadata();
1703+
const creationTime = Number(metadata.creationTime);
1704+
1705+
if (isResourceStale(creationTime)) {
1706+
try {
1707+
await dataset.delete({force: true});
1708+
} catch (e) {
1709+
console.log(`dataset(${dataset.id}).delete() failed`);
1710+
console.log(e);
1711+
}
1712+
}
1713+
}
17121714
}
17131715
});

0 commit comments

Comments
 (0)