connection: add error handling to credentials.

Author: stephenplusplus

lib/common/connection.js

@@ -36,6 +36,12 @@ var METADATA_TOKEN_URL =
 /** @const {object} gcloud-node's package.json file. */
 var PKG = require('../../package.json');
 
+/** @const {array} Required properties for a complete `credentials` object. */
+var REQUIRED_CREDENTIALS = [
+  'client_email',
+  'private_key'
+];
+
 /** @const {string} User agent. */
 var USER_AGENT = 'gcloud-node/' + PKG.version;
 
@@ -95,6 +101,18 @@ function Connection(opts) {
   this.isConnecting = false;
   this.waitQueue = [];
 
+  if (opts.credentials) {
+    var hasRequiredProperties = REQUIRED_CREDENTIALS.every(function(cred) {
+      return !!opts.credentials[cred];
+    });
+    if (hasRequiredProperties) {
+      this.credentials = opts.credentials;
+    } else {
+      throw new Error('A credentials object must contain the following keys: ' +
+          REQUIRED_CREDENTIALS.join(' '));
+    }
+  }
+
   if (opts.credentials && opts.credentials.private_key &&
       opts.credentials.client_email) {
     this.credentials = opts.credentials;

test/common/connection.js

@@ -45,13 +45,24 @@ describe('Connection', function() {
     });
   });
 
-  it('should accept and assign credentials object', function() {
-    var credConnection = new connection.Connection({
-      credentials: privateKeyFileJson
+  describe('credentials object', function() {
+    it('should accept and assign a complete credentials object', function() {
+      var credConnection = new connection.Connection({
+        credentials: privateKeyFileJson
+      });
+      assert.deepEqual(credConnection.credentials, privateKeyFileJson);
+    });
+
+    it('should reject an incomplete credentials object', function() {
+      assert.throws(function() {
+        new connection.Connection({
+          credentials: {}
+        });
+      }, /must contain/);
     });
-    assert.deepEqual(credConnection.credentials, privateKeyFileJson);
   });
 
+
   describe('Token', function() {
     var tokenNeverExpires = new connection.Token('token', new Date(3000, 0, 0));
     var tokenExpired = new connection.Token('token', new Date(2011, 0, 0));