logging: add timestamps to entries

If a timestamp doesn't exist on the Log Entry, the Logging service
inserts a timestamp based on the time it receives the message. Local
and network queuing / latency may cause logs to be delivered in an
order different from the originating source.

Attaching a timestamp at Entry creation time makes avoids this
problem.

Queuing / latency on the client side or on the network may mean that
the Log Entries are received by the service in a different order than
the client.

Author: ofrobots

packages/logging/src/entry.js

@@ -85,6 +85,7 @@ var isCircular = require('is-circular');
 function Entry(metadata, data) {
   this.metadata = metadata;
   this.data = data;
+  this.timestamp = new Date();
 }
 
 /**

packages/logging/system-test/logging.js

@@ -315,36 +315,38 @@ describe('Logging', function() {
     });
 
     it('should write multiple entries to a log', function(done) {
-      log.write(logEntries, options, function(err) {
-        assert.ifError(err);
+      logEntries.forEach(function(entry) {
+        log.write(entry, options, function(err) {
+          assert.ifError(err);
+        });
+      });
 
-        setTimeout(function() {
-          log.getEntries({
-            pageSize: logEntries.length
-          }, function(err, entries) {
-            assert.ifError(err);
+      setTimeout(function() {
+        log.getEntries({
+          pageSize: logEntries.length
+        }, function(err, entries) {
+          assert.ifError(err);
 
-            assert.deepEqual(entries.map(prop('data')).reverse(), [
-              'log entry 1',
-              {
+          assert.deepEqual(entries.map(prop('data')).reverse(), [
+            'log entry 1',
+            {
+              delegate: 'my_username'
+            },
+            {
+              nonValue: null,
+              boolValue: true,
+              arrayValue: [ 1, 2, 3 ]
+            },
+            {
+              nested: {
                 delegate: 'my_username'
-              },
-              {
-                nonValue: null,
-                boolValue: true,
-                arrayValue: [ 1, 2, 3 ]
-              },
-              {
-                nested: {
-                  delegate: 'my_username'
-                }
               }
-            ]);
+            }
+          ]);
 
-            done();
-          });
-        }, WRITE_CONSISTENCY_DELAY_MS);
-      });
+          done();
+        });
+      }, WRITE_CONSISTENCY_DELAY_MS);
     });
 
     it('should write an entry with primitive values', function(done) {

packages/logging/test/log.js

@@ -19,6 +19,7 @@
 var assert = require('assert');
 var extend = require('extend');
 var GrpcServiceObject = require('@google-cloud/common').GrpcServiceObject;
+var prop = require('propprop');
 var proxyquire = require('proxyquire');
 var util = require('@google-cloud/common').util;
 
@@ -137,34 +138,15 @@ describe('Log', function() {
     var SEVERITY = 'severity';
 
     it('should assign severity to a single entry', function() {
-      assert.deepEqual(
-        Log.assignSeverityToEntries_(ENTRIES[0], SEVERITY),
-        [
-          extend(true, {}, ENTRIES[0], {
-            metadata: {
-              severity: SEVERITY
-            }
-          })
-        ]
-      );
+      assert.deepEqual(Log.assignSeverityToEntries_(ENTRIES[0], SEVERITY)
+                           .map(prop('metadata')),
+                       [{severity: SEVERITY}]);
     });
 
     it('should assign severity property to multiple entries', function() {
       assert.deepEqual(
-        Log.assignSeverityToEntries_(ENTRIES, SEVERITY),
-        [
-          extend(true, {}, ENTRIES[0], {
-            metadata: {
-              severity: SEVERITY
-            }
-          }),
-          extend(true, {}, ENTRIES[1], {
-            metadata: {
-              severity: SEVERITY
-            }
-          })
-        ]
-      );
+          Log.assignSeverityToEntries_(ENTRIES, SEVERITY).map(prop('metadata')),
+          [{severity: SEVERITY}, {severity: SEVERITY}]);
     });
 
     it('should not affect original array', function() {