feature: commit timestamp (#163)

Author: callmehiphop

handwritten/spanner/src/index.js

@@ -213,6 +213,15 @@ function Spanner(options) {
 
 util.inherits(Spanner, commonGrpc.Service);
 
+/**
+ * Placeholder used to auto populate a column with the commit timestamp.
+ * This can only be used for timestamp columns that have set the option
+ * "(allow_commit_timestamp=true)" in the schema.
+ *
+ * @type {string}
+ */
+Spanner.COMMIT_TIMESTAMP = 'spanner.commit_timestamp()';
+
 /**
  * Helper function to get a Cloud Spanner Date object.
  *

handwritten/spanner/src/v1/spanner_client.js

@@ -205,6 +205,7 @@ class SpannerClient {
   static get scopes() {
     return [
       'https://www.googleapis.com/auth/cloud-platform',
+      'https://www.googleapis.com/auth/spanner.admin',
       'https://www.googleapis.com/auth/spanner.data',
     ];
   }

handwritten/spanner/system-test/spanner.js

@@ -66,7 +66,7 @@ describe('Spanner', function() {
 
       insertData.Key = id;
 
-      table.insert(insertData, function(err) {
+      table.insert(insertData, function(err, insertResp) {
         if (err) {
           callback(err);
           return;
@@ -79,13 +79,13 @@ describe('Spanner', function() {
               id: id,
             },
           },
-          function(err, rows) {
+          function(err, rows, readResp) {
             if (err) {
               callback(err);
               return;
             }
 
-            callback(null, rows.shift());
+            callback(null, rows.shift(), insertResp, readResp);
           }
         );
       });
@@ -110,7 +110,8 @@ describe('Spanner', function() {
               FloatArray ARRAY<FLOAT64>,
               IntArray ARRAY<INT64>,
               StringArray ARRAY<STRING(MAX)>,
-              TimestampArray ARRAY<TIMESTAMP>
+              TimestampArray ARRAY<TIMESTAMP>,
+              CommitTimestamp TIMESTAMP OPTIONS (allow_commit_timestamp=true)
             ) PRIMARY KEY (Key)
           `,
         },
@@ -600,6 +601,24 @@ describe('Spanner', function() {
       });
     });
 
+    describe('commit timestamp', function() {
+      it('should accept the commit timestamp placeholder', function(done) {
+        var data = {CommitTimestamp: Spanner.COMMIT_TIMESTAMP};
+
+        insert(data, function(err, row, commitResponse) {
+          assert.ifError(err);
+
+          var timestampFromCommit = fromProtoToDate(
+            commitResponse.commitTimestamp
+          );
+          var timestampFromRead = row.toJSON().CommitTimestamp;
+
+          assert.deepEqual(timestampFromCommit, timestampFromRead);
+          done();
+        });
+      });
+    });
+
     it('should throw an error for incorrect value types', function(done) {
       table.insert({BoolValue: 'abc'}, function(err) {
         assert(err);
@@ -3584,3 +3603,8 @@ function wait(time) {
     setTimeout(resolve, time);
   });
 }
+
+function fromProtoToDate(obj) {
+  var milliseconds = parseInt(obj.nanos, 10) / 1e6;
+  return new Date(parseInt(obj.seconds, 10) * 1000 + milliseconds);
+}