tests: convert storage to mockery

Author: stephenplusplus

test/storage/bucket.js

@@ -14,13 +14,14 @@
  * limitations under the License.
  */
 
-/*global describe, it, beforeEach */
+/*global describe, it, beforeEach, before, after */
 
 'use strict';
 
 var assert = require('assert');
-var duplexify = require('duplexify');
+var mockery = require('mockery');
 var request = require('request');
+var Stream = require('stream');
 var util = require('../../lib/common/util.js');
 
 function FakeFile(bucket, name, metadata) {
@@ -29,33 +30,24 @@ function FakeFile(bucket, name, metadata) {
   this.metadata = metadata;
   this.createWriteStream = function(options) {
     this.metadata = options.metadata;
-    var dup = duplexify();
-    dup._write = function() {
-      dup.emit('complete');
+    var ws = new Stream.Writable();
+    ws.write = function() {
+      ws.emit('complete');
     };
-    return dup;
+    return ws;
   };
 }
 
-var Bucket = require('sandboxed-module')
-  .require('../../lib/storage/bucket.js', {
-    requires: {
-      './file.js': FakeFile,
-      request: fakeRequest
-    }
-  });
-
 var request_Cached = request;
 var request_Override;
 
 function fakeRequest() {
   var args = [].slice.apply(arguments);
-  var results = (request_Override || request_Cached).apply(null, args);
-  request_Override = null;
-  return results;
+  return (request_Override || request_Cached).apply(null, args);
 }
 
 describe('Bucket', function() {
+  var Bucket;
   var BUCKET_NAME = 'test-bucket';
   var bucket;
   var options = {
@@ -64,7 +56,23 @@ describe('Bucket', function() {
     }
   };
 
+  before(function() {
+    mockery.registerMock('./file.js', FakeFile);
+    mockery.registerMock('request', fakeRequest);
+    mockery.enable({
+      useCleanCache: true,
+      warnOnUnregistered: false
+    });
+    Bucket = require('../../lib/storage/bucket.js');
+  });
+
+  after(function() {
+    mockery.deregisterAll();
+    mockery.disable();
+  });
+
   beforeEach(function() {
+    request_Override = null;
     bucket = new Bucket(options, BUCKET_NAME);
   });
 
@@ -351,13 +359,14 @@ describe('Bucket', function() {
       var fakeFile = new FakeFile(bucket, 'file-name');
       var options = { destination: fakeFile };
       fakeFile.createWriteStream = function(options) {
-        var dup = duplexify();
+        var ws = new Stream.Writable();
+        ws.write = util.noop;
         setImmediate(function() {
           var expectedContentType = 'application/json; charset=utf-8';
           assert.equal(options.metadata.contentType, expectedContentType);
           done();
         });
-        return dup;
+        return ws;
       };
       bucket.upload(filepath, options, assert.ifError);
     });
@@ -366,13 +375,14 @@ describe('Bucket', function() {
       var fakeFile = new FakeFile(bucket, 'file-name');
       var options = { destination: fakeFile };
       fakeFile.createWriteStream = function(options) {
-        var dup = duplexify();
+        var ws = new Stream.Writable();
+        ws.write = util.noop;
         setImmediate(function() {
           var expectedContentType = 'text/plain; charset=utf-8';
           assert.equal(options.metadata.contentType, expectedContentType);
           done();
         });
-        return dup;
+        return ws;
       };
       bucket.upload(textFilepath, options, assert.ifError);
     });
@@ -382,12 +392,13 @@ describe('Bucket', function() {
       var metadata = { contentType: 'made-up-content-type' };
       var options = { destination: fakeFile, metadata: metadata };
       fakeFile.createWriteStream = function(options) {
-        var dup = duplexify();
+        var ws = new Stream.Writable();
+        ws.write = util.noop;
         setImmediate(function() {
           assert.equal(options.metadata.contentType,  metadata.contentType);
           done();
         });
-        return dup;
+        return ws;
       };
       bucket.upload(filepath, options, assert.ifError);
     });
@@ -396,12 +407,13 @@ describe('Bucket', function() {
       var fakeFile = new FakeFile(bucket, 'file-name');
       var options = { destination: fakeFile, resumable: false };
       fakeFile.createWriteStream = function(options) {
-        var dup = duplexify();
+        var ws = new Stream.Writable();
+        ws.write = util.noop;
         setImmediate(function() {
           assert.strictEqual(options.resumable, false);
           done();
         });
-        return dup;
+        return ws;
       };
       bucket.upload(filepath, options, assert.ifError);
     });
@@ -411,11 +423,11 @@ describe('Bucket', function() {
       var fakeFile = new FakeFile(bucket, 'file-name');
       var options = { destination: fakeFile };
       fakeFile.createWriteStream = function() {
-        var dup = duplexify();
+        var ws = new Stream.Writable();
         setImmediate(function() {
-          dup.emit('error', error);
+          ws.emit('error', error);
         });
-        return dup;
+        return ws;
       };
       bucket.upload(filepath, options, function(err) {
         assert.equal(err, error);

test/storage/file.js

@@ -14,7 +14,7 @@
  * limitations under the License.
  */
 
-/*global describe, it, beforeEach */
+/*global describe, it, beforeEach, before, after */
 
 'use strict';
 
@@ -24,6 +24,7 @@ var crc = require('fast-crc32c');
 var crypto = require('crypto');
 var duplexify = require('duplexify');
 var extend = require('extend');
+var mockery = require('mockery');
 var nodeutil = require('util');
 var request = require('request');
 var stream = require('stream');
@@ -37,22 +38,23 @@ function FakeDuplexify() {
   if (!(this instanceof FakeDuplexify)) {
     return new FakeDuplexify();
   }
-  duplexify.call(this);
+  stream.Duplex.call(this);
+  this._read = util.noop;
+  this._write = util.noop;
   this.setReadable = function(setReadableStream) {
     readableStream = setReadableStream;
   };
   this.setWritable = function(setWritableStream) {
     writableStream = setWritableStream;
   };
 }
-nodeutil.inherits(FakeDuplexify, duplexify);
+nodeutil.inherits(FakeDuplexify, stream.Duplex);
 
 var makeWritableStream_Override;
 var fakeUtil = extend({}, util, {
   makeWritableStream: function() {
     var args = [].slice.call(arguments);
     (makeWritableStream_Override || util.makeWritableStream).apply(null, args);
-    makeWritableStream_Override = null;
   }
 });
 
@@ -62,7 +64,6 @@ var request_Override;
 function fakeRequest() {
   var args = [].slice.apply(arguments);
   var results = (request_Override || request_Cached).apply(null, args);
-  request_Override = null;
   return results;
 }
 
@@ -81,17 +82,8 @@ function FakeConfigStore() {
   };
 }
 
-var File = require('sandboxed-module')
-  .require('../../lib/storage/file.js', {
-    requires: {
-      configstore: FakeConfigStore,
-      duplexify: FakeDuplexify,
-      request: fakeRequest,
-      '../common/util': fakeUtil
-    }
-  });
-
 describe('File', function() {
+  var File;
   var FILE_NAME = 'file-name.png';
   var options = {
     makeAuthorizedRequest_: function(req, callback) {
@@ -102,7 +94,27 @@ describe('File', function() {
   var file;
   var directoryFile;
 
+  before(function() {
+    mockery.registerMock('configstore', FakeConfigStore);
+    mockery.registerMock('duplexify', FakeDuplexify);
+    mockery.registerMock('request', fakeRequest);
+    mockery.registerMock('../common/util.js', fakeUtil);
+    mockery.enable({
+      useCleanCache: true,
+      warnOnUnregistered: false
+    });
+    File = require('../../lib/storage/file.js');
+  });
+
+  after(function() {
+    mockery.deregisterAll();
+    mockery.disable();
+  });
+
   beforeEach(function() {
+    makeWritableStream_Override = null;
+    request_Override = null;
+
     file = new File(bucket, FILE_NAME);
     file.makeReq_ = util.noop;
 
@@ -1009,17 +1021,17 @@ describe('File', function() {
         callback(metadata);
       };
 
-      var stream = duplexify();
+      var ws = new stream.Writable();
 
-      stream
+      ws
         .on('error', done)
         .on('complete', function(meta) {
           assert.deepEqual(meta, metadata);
           assert.deepEqual(file.metadata, metadata);
           done();
         });
 
-      file.startSimpleUpload_(stream, metadata);
+      file.startSimpleUpload_(ws, metadata);
     });
   });
 });