deps: remove lodash omit, omitby, and pick (#565)

* deps: remove omit, omitby, pick

* 🦉 Updates from OwlBot

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>

Author: freelerobot

packages/handwritten/package.json

@@ -47,9 +47,6 @@
     "@types/hapi__hapi": "^20.0.5",
     "@types/json-stable-stringify": "^1.0.32",
     "@types/koa": "^2.0.48",
-    "@types/lodash.omit": "^4.5.6",
-    "@types/lodash.omitby": "^4.6.6",
-    "@types/lodash.pick": "^4.4.6",
     "@types/lodash.random": "^3.2.6",
     "@types/lodash.without": "^4.4.6",
     "@types/mocha": "^8.0.0",
@@ -70,9 +67,6 @@
     "json-stable-stringify": "^1.0.1",
     "koa": "^2.7.0",
     "linkinator": "^2.0.0",
-    "lodash.omit": "^4.5.0",
-    "lodash.omitby": "^4.6.0",
-    "lodash.pick": "^4.4.0",
     "lodash.random": "^3.2.0",
     "lodash.without": "^4.4.0",
     "mocha": "^8.0.0",

packages/handwritten/system-test/error-reporting.ts

@@ -29,8 +29,6 @@ import {
   ErrorsApiTransport,
 } from '../utils/errors-api-transport';
 
-import pick = require('lodash.pick');
-import omitBy = require('lodash.omitby');
 import * as uuid from 'uuid';
 import * as util from 'util';
 import * as path from 'path';
@@ -57,10 +55,14 @@ class InstancedEnv {
   }
 
   _captureProcessProperties() {
-    return omitBy(
-      pick(process.env, envKeys),
-      value => typeof value !== 'string'
+    const envVars = {...process.env};
+    Object.entries(envVars).forEach(
+      ([key, value]) =>
+        envKeys.includes(key) &&
+        typeof value !== 'string' &&
+        delete envVars[key]
     );
+    return envVars;
   }
 
   sterilizeProcess() {

packages/handwritten/test/unit/request-extractors/manual.ts

@@ -12,7 +12,6 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import omit = require('lodash.omit');
 import {manualRequestInformationExtractor} from '../../../src/request-extractors/manual';
 import {Fuzzer} from '../../../utils/fuzzer';
 import {deepStrictEqual} from '../../util';
@@ -58,50 +57,54 @@ describe('manualRequestInformationExtractor', () => {
           'the output of the request extraction',
         ].join(' ')
       );
+      const {method, ...sansMethod} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(omit(FULL_VALID_INPUT, 'method')),
+        manualRequestInformationExtractor(sansMethod),
         Object.assign({}, FULL_VALID_INPUT, {method: ''}),
         [
           'Given a full valid input object sans the method property values',
           'should be reflected by the output of the request extraction',
         ].join(' ')
       );
+      const {url, ...sansUrl} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(omit(FULL_VALID_INPUT, 'url')),
+        manualRequestInformationExtractor(sansUrl),
         Object.assign({}, FULL_VALID_INPUT, {url: ''}),
         [
           'Given a valid input sans the url property these values should be',
           'reflected by the output of the request extraction',
         ].join('')
       );
+      const {userAgent, ...sansUserAgent} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(omit(FULL_VALID_INPUT, 'userAgent')),
+        manualRequestInformationExtractor(sansUserAgent),
         Object.assign({}, FULL_VALID_INPUT, {userAgent: ''}),
         [
           'Given a full valid input sans the userAgent property these values',
           'should be reflected by the output of the request extraction',
         ].join('')
       );
+      const {referrer, ...sansReferrer} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(omit(FULL_VALID_INPUT, 'referrer')),
+        manualRequestInformationExtractor(sansReferrer),
         Object.assign({}, FULL_VALID_INPUT, {referrer: ''}),
         [
           'Given a full valid input sans the referrer property these values',
           'should be reflected by the output of the request extraction',
         ].join('')
       );
+      const {statusCode, ...sansStatusCode} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(omit(FULL_VALID_INPUT, 'statusCode')),
+        manualRequestInformationExtractor(sansStatusCode),
         Object.assign({}, FULL_VALID_INPUT, {statusCode: 0}),
         [
           'Given a full valid input sans the statusCode property these values',
           'should be reflected by the output of the request extraction',
         ].join('')
       );
+      const {remoteAddress, ...sansRemoteAddress} = FULL_VALID_INPUT;
       deepStrictEqual(
-        manualRequestInformationExtractor(
-          omit(FULL_VALID_INPUT, 'remoteAddress')
-        ),
+        manualRequestInformationExtractor(sansRemoteAddress),
         Object.assign({}, FULL_VALID_INPUT, {remoteAddress: ''}),
         [
           'Given a valid input sans the remoteAddress property these values',

packages/handwritten/test/unit/service-configuration.ts

@@ -14,7 +14,6 @@
 
 import * as assert from 'assert';
 import {describe, beforeEach, after, it} from 'mocha';
-import omitBy = require('lodash.omitby');
 import {FakeConfiguration as Configuration} from '../fixtures/configuration';
 import {deepStrictEqual} from '../util';
 const level = process.env.GCLOUD_ERRORS_LOGLEVEL;
@@ -46,20 +45,13 @@ function setEnv(envData: {
 }) {
   Object.assign(
     process.env,
-    omitBy(
-      {
-        GAE_SERVICE: envData.gaeServiceName,
-        GAE_VERSION: envData.gaeServiceVersion,
-        GAE_MODULE_NAME: envData.gaeModuleName,
-        GAE_MODULE_VERSION: envData.gaeModuleVersion,
-        FUNCTION_NAME: envData.functionName,
-        K_SERVICE: envData.kService,
-        K_REVISION: envData.kRevision,
-      },
-      val => {
-        return typeof val !== 'string';
-      }
-    )
+    envData.gaeServiceName && {GAE_SERVICE: envData.gaeServiceName},
+    envData.gaeServiceVersion && {GAE_VERSION: envData.gaeServiceVersion},
+    envData.gaeModuleName && {GAE_MODULE_NAME: envData.gaeModuleName},
+    envData.gaeModuleVersion && {GAE_MODULE_VERSION: envData.gaeModuleVersion},
+    envData.functionName && {FUNCTION_NAME: envData.functionName},
+    envData.kService && {K_SERVICE: envData.kService},
+    envData.kRevision && {K_REVISION: envData.kRevision}
   );
 }
 function restoreServiceConfigEnv() {