Skip to content

Commit a64518e

Browse files
circle: fix build issues (#2478)
change coveralls token
1 parent c886e0b commit a64518e

2 files changed

Lines changed: 10 additions & 6 deletions

File tree

scripts/build.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ var modules = Module.getUpdated();
5151

5252
if (!modules.length && !ci.isReleaseBuild()) {
5353
echo('No code changes found, exiting early.');
54-
exit();
54+
exit(1);
5555
}
5656

5757
Module.buildDocs();

scripts/circle/test.sh

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,8 +14,6 @@
1414
# See the License for the specific language governing permissions and
1515
# limitations under the License.
1616

17-
set -e
18-
1917
rebuild () {
2018
for dir in packages/*; do
2119
test -d "$dir" || continue
@@ -44,7 +42,15 @@ npm install
4442
npm run lint
4543
node ./scripts/build.js
4644

47-
export COVERALLS_REPO_TOKEN="kEhKxvu3L9Z4GiClA9LcKYk7G9i9dl83k"
45+
if [ "$?" == "1" ]
46+
then
47+
# No code changes. Exit early.
48+
set -e
49+
exit 0
50+
set +e
51+
fi
52+
53+
export COVERALLS_REPO_TOKEN="vKZ7a3PpW0lRBRWC12dPw2EiZE5ml962J"
4854
export CIRCLE_ARTIFACTS="$(pwd)/.coverage"
4955
npm run postinstall # installs all modules
5056
npm run coveralls
@@ -63,5 +69,3 @@ nvm install v8 && nvm use v8
6369
rebuild
6470
npm run lint
6571
node ./scripts/build.js
66-
67-
set +e

0 commit comments

Comments
 (0)